Skip to content

fix(i18n): enforce bundled locale parity - #2998

Closed
lntutor wants to merge 1 commit into
Chainlit:mainfrom
lntutor:fix/translation-parity
Closed

fix(i18n): enforce bundled locale parity#2998
lntutor wants to merge 1 commit into
Chainlit:mainfrom
lntutor:fix/translation-parity

Conversation

@lntutor

@lntutor lntutor commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Fixes #2993

Restore the six missing bundled translation keys and add a regression test that compares every shipped locale against en-US.json. Future key drift now fails with the affected locale and key in the pytest diff.

Validation:

  • uv run pytest backend/tests/test_translations.py (35 passed)
  • uv run scripts/lint.py backend/tests/test_translations.py
  • uv run scripts/format.py --check backend/tests/test_translations.py

Summary by cubic

Enforces full parity between all bundled locales and en-US.json by restoring six missing keys and adding a parity test. Fixes #2993.

  • Bug Fixes
    • Restored favorites.remove in ar-SA and da-DK.
    • Restored fileUpload.browse in ja.
    • Added components.DatePickerInput.placeholder.{single,range} in de-DE, it, and ko.
    • Added a regression test in backend/tests/test_translations.py that compares every shipped locale to en-US.json and fails on drift.

Written for commit 74edef0. Summary will update on new commits.

Review in cubic

Co-Authored-By: OpenAI Codex <noreply@openai.com>
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. translation Translation or localisation of strings. unit-tests Has unit tests. labels Jul 30, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Re-trigger cubic

@lntutor

lntutor commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

Closing to avoid competing with the earlier #2994 and #2995 translation-parity fixes. Sorry for the overlap.

@lntutor lntutor closed this Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files. translation Translation or localisation of strings. unit-tests Has unit tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

i18n: 6 translation keys missing across 6 locales, and nothing enforces parity

1 participant