Skip to content

Fix: re-raise exceptions instead of silently swallowing them #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luizbon wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: re-raise exceptions instead of silently swallowing them #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions alphaess/alphaess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ async def getESSList(self) -> Optional(list):

except Exception as e:
logger.error(f"Error: {e} when calling {resource}")
raise

async def getLastPowerData(self, sysSn) -> Optional(list):
"""According SN to get real-time power data"""
Expand All @@ -78,6 +79,7 @@ async def getLastPowerData(self, sysSn) -> Optional(list):

except Exception as e:
logger.error(f"Error: {e} when calling {resource}")
raise

async def getOneDayPowerBySn(self, sysSn, queryDate=None) -> Optional(list):
"""According SN to get system power data"""
Expand All @@ -92,6 +94,7 @@ async def getOneDayPowerBySn(self, sysSn, queryDate=None) -> Optional(list):

except Exception as e:
logger.error(f"Error: {e} when calling {resource}")
raise

async def getSumDataForCustomer(self, sysSn) -> Optional(list):
"""According SN to get System Summary data"""
Expand All @@ -104,6 +107,7 @@ async def getSumDataForCustomer(self, sysSn) -> Optional(list):

except Exception as e:
logger.error(f"Error: {e} when calling {resource}")
raise

async def getOneDateEnergyBySn(self, sysSn, queryDate=None) -> Optional(list):
"""According SN to get System Energy Data"""
Expand All @@ -118,6 +122,7 @@ async def getOneDateEnergyBySn(self, sysSn, queryDate=None) -> Optional(list):

except Exception as e:
logger.error(f"Error: {e} when calling {resource}")
raise

async def getChargeConfigInfo(self, sysSn) -> Optional(list):
"""According SN to get charging setting information"""
Expand All @@ -130,6 +135,7 @@ async def getChargeConfigInfo(self, sysSn) -> Optional(list):

except Exception as e:
logger.error(f"Error: {e} when calling {resource}")
raise

async def getDisChargeConfigInfo(self, sysSn) -> Optional(list):
"""According to SN discharge setting information"""
Expand All @@ -142,6 +148,7 @@ async def getDisChargeConfigInfo(self, sysSn) -> Optional(list):

except Exception as e:
logger.error(f"Error: {e} when calling {resource}")
raise

async def getEvChargerConfigList(self, sysSn) -> Optional(list):
"""According to SN get Ev Charger Config List"""
Expand All @@ -154,6 +161,7 @@ async def getEvChargerConfigList(self, sysSn) -> Optional(list):

except Exception as e:
logger.error(f"Error: {e} when calling {resource}")
raise

async def setEvChargerCurrentsBySn(self, sysSn, currentsetting) -> Optional(list):
"""According to SN set Ev Charger Currents"""
Expand All @@ -171,6 +179,7 @@ async def setEvChargerCurrentsBySn(self, sysSn, currentsetting) -> Optional(list

except Exception as e:
logger.error(f"Error: {e} when calling {resource}")
raise

async def getEvChargerCurrentsBySn(self, sysSn) -> Optional(list):
"""According to SN get Ev Charger Currents"""
Expand All @@ -183,6 +192,7 @@ async def getEvChargerCurrentsBySn(self, sysSn) -> Optional(list):

except Exception as e:
logger.error(f"Error: {e} when calling {resource}")
raise

async def getEvChargerStatusBySn(self, sysSn, evchargerSn) -> Optional(list):
"""According to SN get Ev Charger Status"""
Expand All @@ -195,6 +205,7 @@ async def getEvChargerStatusBySn(self, sysSn, evchargerSn) -> Optional(list):

except Exception as e:
logger.error(f"Error: {e} when calling {resource}")
raise

async def remoteControlEvCharger(self, sysSn, evchargerSn, controlMode) -> Optional(dict):
"""According SN to Remote Control Ev Charger"""
Expand All @@ -213,6 +224,7 @@ async def remoteControlEvCharger(self, sysSn, evchargerSn, controlMode) -> Optio

except Exception as e:
logger.error(f"Error: {e} when calling {resource}")
raise

async def bindSn(self, sysSn, code) -> Optional(dict):
"""According to SN to Bind SN"""
Expand All @@ -230,6 +242,7 @@ async def bindSn(self, sysSn, code) -> Optional(dict):

except Exception as e:
logger.error(f"Error: {e} when calling {resource}")
raise

async def getVerificationCode(self, sysSn, checkCode) -> Optional(dict):
"""According SN to Get Verification Code"""
Expand All @@ -247,6 +260,7 @@ async def getVerificationCode(self, sysSn, checkCode) -> Optional(dict):

except Exception as e:
logger.error(f"Error: {e} when calling {resource}")
raise

async def unBindSn(self, sysSn) -> Optional(dict):
"""According SN to UnBind SN"""
Expand All @@ -263,6 +277,7 @@ async def unBindSn(self, sysSn) -> Optional(dict):

except Exception as e:
logger.error(f"Error: {e} when calling {resource}")
raise

async def updateChargeConfigInfo(self, sysSn, batHighCap, gridCharge, timeChae1, timeChae2, timeChaf1,
timeChaf2) -> Optional(dict):
Expand All @@ -286,6 +301,7 @@ async def updateChargeConfigInfo(self, sysSn, batHighCap, gridCharge, timeChae1,

except Exception as e:
logger.error(f"Error: {e} when calling {resource}")
raise

async def updateDisChargeConfigInfo(self, sysSn, batUseCap, ctrDis, timeDise1, timeDise2, timeDisf1,
timeDisf2) -> Optional(dict):
Expand All @@ -309,6 +325,7 @@ async def updateDisChargeConfigInfo(self, sysSn, batUseCap, ctrDis, timeDise1, t

except Exception as e:
logger.error(f"Error: {e} when calling {resource}")
raise

async def getIPData(self) -> Optional(dict):
ENDPOINTS = {
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

setup(
name="alphaessopenapi",
version="0.0.19",
version="0.0.20",
author="Charles Gillanders",
author_email="charles@charlesgillanders.com",
description="A python library to retrieve energy statistics from your Alpha ESS inverter by polling the Official Alpha ESS Open API.",
Expand Down