fix(workspace): make scheduled deletion purge reliable - #910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scheduled workspace deletion was not completing: the hourly purge crashed while deleting a workspace's messages, so no due workspace was ever removed. This makes the purge correct, resilient, and safe to run alongside live traffic.
What changed
Notable
While verifying against TimescaleDB's documentation, the decompression-limit setting used a parameter name that does not exist in TimescaleDB, which would fail at runtime. It has been corrected and centralized in one shared helper (also removing a duplicated statement), with a test that pins the exact name.
Test plan
pnpm --filter @chatbotx.io/business exec vitest run— 730 passing (adds coverage for the per-workspace guard, hypertable draining, and skip-disconnect-when-no-credentials)pnpm --filter @chatbotx.io/database exec vitest run— 378 passing (adds the decompression-parameter-name test)pnpm --filter worker test purge-workspacesNotes for reviewers