new ginsu constructor - #63
Merged
Merged
Conversation
samtkaplan
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional strict Ginsu constructor that deduce the origin and extent of the domain in xy directions based on the source-receiver geometry.
Moreover, the padding in this constructor has a different interpretation: it is the exact padding to extend the box encapsulating sources and receivers. And this concept has nothing to do with the aperture used in imaging, which is based on source-receiver midpoints.
As a result, the created Ginsu ensures that domain and range of the member JopPad operators are the same in the xy direction, except for
AandBwhich will have their range shrunk by the damping region.