Check application height in post-upgrade checks - #69
Draft
qezz wants to merge 1 commit into
Draft
Conversation
Application height is updated after the block is committed and after it is executed/applied. We need this height to know whether the node actually managed to apply the new block, or whether it failed to do so. The behavior we saw was: when rolling out a "wrong" version of the software, the node commits a block at height `N`, but fails to execute it. Blazar happily reports that the height `N` has been reached, and marks the upgrade as "successful". That works fine for the most upgrades, e.g. when a new version is released and new upgrade handlers are expected expected to execute properly. When the version is wrong, the upgrade handlers are not found, the execution fails, but Blazar still considers it successful. This change should prevent this issue from happening.
Contributor
Author
|
interesting, CI reports a |
Contributor
Author
|
here we go it's not an issue in real code, only in tests, which run in parallel, i.e. it triggers the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Application height is updated after the block is committed and after it is executed/applied.
We need this height to know whether the node actually managed to apply the new block, or whether it failed to do so.
The behavior we saw was: when rolling out a "wrong" version of the software, the node commits a block at height
N, but fails to execute it. Blazar happily reports that the heightNhas been reached, and marks the upgrade as "successful".That works fine for the most upgrades, e.g. when a new version is released and new upgrade handlers are expected expected to execute properly. When the version is wrong, the upgrade handlers are not found, the execution fails, but Blazar still considers it successful.
This change should prevent this issue from happening.