Keep decimals in --at timestamp labels; add --name for a stable montage file name - #1
Open
morinpic wants to merge 1 commit into
Open
Keep decimals in --at timestamp labels; add --name for a stable montage file name#1morinpic wants to merge 1 commit into
morinpic wants to merge 1 commit into
Conversation
… montage file name - format_ts: fractional seconds (e.g. --at 3.5) render as M:SS.d instead of being truncated to M:SS, so two pinpoint frames inside the same second stay distinguishable in burn-ins and montage cell labels. Integer input is unchanged. - --name NAME: write the montage as <output>/<NAME>.jpg instead of the run-id suffixed default. Rejects path separators; a trailing .jpg is accepted. Re-runs overwrite the file, which is what pipelines want. - README and --help updated; smoke tests for both. Claude-Session: https://claude.ai/code/session_01XQ8xsAfAFY4JANNooHJTax
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Feeding
--ata list of sub-second times (from an external detector) worked, but two things got in the way of using vshot inside a pipeline:M:SS, so--at 422.5,422.9both showed as7:02. The decimals were already kept in the frame filenames, just not in the labels.--jsonor glob*_montage_*.jpgto find it.What
format_tskeeps one decimal for fractional input:3.5→0:03.5. Integer input still renders as0:03.--name NAME: the montage is written to<output>/<NAME>.jpg. Path separators are rejected, a trailing.jpgis tolerated, re-runs overwrite.--help, README options table and examples updated.--name(creates, no random-suffixed file, re-run keeps one file, rejects../), fractional and integer filename suffixes.Checked
bash -n vshottests/smoke.sh: 66 passed, 0 failed (macOS, Homebrew ffmpeg 8.1 without drawtext, ImageMagick 7)--attimes over a 20-minute clip → one montage in 5 s, labels like7:00.5https://claude.ai/code/session_01XQ8xsAfAFY4JANNooHJTax