fix Alembic named container rendering - #993
Merged
joe-clickhouse merged 2 commits intoAug 24, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Alembic autogeneration for Nested and named Tuple types, preserving field names in generated migrations.
Changes:
- Renders named containers through
sqla_type_from_name. - Adds required migration imports.
- Adds unit, integration, and changelog coverage.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
clickhouse_connect/cc_sqlalchemy/alembic/impl.py |
Detects and losslessly renders named containers. |
clickhouse_connect/cc_sqlalchemy/alembic/adapter.py |
Adds the generated migration import. |
tests/unit_tests/test_sqlalchemy/test_alembic.py |
Covers nested container rendering and imports. |
tests/integration_tests/test_sqlalchemy/test_alembic.py |
Verifies live migration round trips. |
CHANGELOG.md |
Documents the bug fix. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…rs-invalid-or-lossy-python-for-nested-and-named-tuple # Conflicts: # CHANGELOG.md # tests/integration_tests/test_sqlalchemy/test_alembic.py # tests/unit_tests/test_sqlalchemy/test_alembic.py
joe-clickhouse
deleted the
joe/988-alembic-renders-invalid-or-lossy-python-for-nested-and-named-tuple
branch
August 24, 2026 15:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Alembic autogenerate now renders
Nestedand namedTuplecolumns through raw ClickHouse type strings. Generated migrations import successfully, preserve field names through nested containers, and no longer repeat type changes.Closes #988
Checklist
Delete items not relevant to your PR: