Skip to content

Fix trigger fidelity and polish the playground - #12

Open
Co-Messi wants to merge 11 commits into
mainfrom
codex/review-remediation
Open

Fix trigger fidelity and polish the playground#12
Co-Messi wants to merge 11 commits into
mainfrom
codex/review-remediation

Conversation

@Co-Messi

Copy link
Copy Markdown
Owner

Summary

  • fix GitHub Actions trigger fidelity for globstars, tag/path behavior, commit skip directives, invalid filter combinations, empty and absent pushes, filtered-array expressions, and oversized matrices
  • make zero-config git inference distinguish outgoing commits from net file diffs
  • align release documentation and package metadata with the verified behavior
  • polish the playground around a browser-first CTA, guided ownership, contextual next actions, honest share privacy, meaningful motion, and a mobile verdict summary

Verification

  • npm run check — 13 test files, 171 tests passed
  • npm run build:web
  • npm pack --dry-run --json --ignore-scriptsactwhy@0.1.1, CLI bundle included
  • node dist/actwhy.js --version0.1.1
  • npm audit --omit=dev --audit-level=high — 0 vulnerabilities
  • git diff --check
  • desktop and 390×844 mobile browser QA, including responsive overflow, accessible control names, duplicate IDs, contextual actions, commit-message visibility, and console errors
  • independent code review completed with no remaining blocking findings

Notes

  • This PR does not publish the npm package.
  • This PR is intentionally unmerged for maintainer review.

@vercel

vercel Bot commented Jul 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
actwhy Ready Ready Preview, Comment Jul 24, 2026 6:31am

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ea7665e873

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/core/evaluate.ts
Comment on lines 301 to +304
if (matrix.overLimit) {
warnings.push({
code: "matrix-over-limit",
message: `job "${job.id.value}": ${matrix.note}`,
});
return {
...base,
verdict: "error",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Evaluate the job if before failing over-limit matrices

When a job has a static matrix above 256 but its job-level if is false for the simulated event, this early return reports a matrix-over-limit job error before the condition is evaluated. GitHub evaluates jobs.<job_id>.if before applying strategy.matrix, so a branch-gated or otherwise skipped job should stay skipped and the oversized matrix should not affect the verdict; otherwise actwhy produces a false error for workflows GitHub would skip cleanly.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant