Fix trigger fidelity and polish the playground - #12
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ea7665e873
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (matrix.overLimit) { | ||
| warnings.push({ | ||
| code: "matrix-over-limit", | ||
| message: `job "${job.id.value}": ${matrix.note}`, | ||
| }); | ||
| return { | ||
| ...base, | ||
| verdict: "error", |
There was a problem hiding this comment.
Evaluate the job
if before failing over-limit matrices
When a job has a static matrix above 256 but its job-level if is false for the simulated event, this early return reports a matrix-over-limit job error before the condition is evaluated. GitHub evaluates jobs.<job_id>.if before applying strategy.matrix, so a branch-gated or otherwise skipped job should stay skipped and the oversized matrix should not affect the verdict; otherwise actwhy produces a false error for workflows GitHub would skip cleanly.
Useful? React with 👍 / 👎.
Summary
Verification
npm run check— 13 test files, 171 tests passednpm run build:webnpm pack --dry-run --json --ignore-scripts—actwhy@0.1.1, CLI bundle includednode dist/actwhy.js --version—0.1.1npm audit --omit=dev --audit-level=high— 0 vulnerabilitiesgit diff --checkNotes