Implement distribution of worker threads across multiple instances of the servers#52
Open
julie-is-late wants to merge 55 commits into
Open
Implement distribution of worker threads across multiple instances of the servers#52julie-is-late wants to merge 55 commits into
julie-is-late wants to merge 55 commits into
Conversation
ensure no connections between components rework of rabbitmq connections to separate them from websocket connections restructure datahandling to not be tied to websockets
…fied across severs switch from ECDSA to RSA keys refactor loading to come from config
ObsessiveOrange
requested changes
Mar 15, 2017
| return []dhClosure{toSenderClosure{msg: messages.NewEmptyResponse(messages.StatusUnauthorized, f.Tag)}}, nil | ||
| } | ||
|
|
||
| ack() // ack just before appending so if it fails in the middle it doesn't re-enqueue it |
Member
There was a problem hiding this comment.
I think we should still ack after, since CPAppendFileChange returns an error for CAS mismatches, doesn't it?
Member
Author
There was a problem hiding this comment.
yeah you're right that it does. hmm, i guess I'm more concerned about it getting stuck than I am about it failing the cas check
Member
There was a problem hiding this comment.
Ok. sounds good. Could we add a todo to verify that this works after deployment
| }) | ||
| // I don't know what to do with this error, it can only happen if we disconnect from rabbit, | ||
| // so it means we have bigger issues | ||
| // FIXME: is this fatal? |
Member
There was a problem hiding this comment.
Hmm, I think this is fatal. Since the server is now in a potentially un-recoverable state, let's just kill it. The daemon can restart it if needed.
Signed-off-by: Benedict Wong <bennydictwong@gmail.com>
Signed-off-by: Benedict Wong <bennydictwong@gmail.com>
Signed-off-by: Benedict Wong <bennydictwong@gmail.com>
Signed-off-by: Benedict Wong <bennydictwong@gmail.com>
Signed-off-by: Benedict Wong <bennydictwong@gmail.com>
Signed-off-by: Benedict Wong <bennydictwong@gmail.com>
Signed-off-by: Benedict Wong <bennydictwong@gmail.com>
Signed-off-by: Benedict Wong <bennydictwong@gmail.com>
Signed-off-by: Benedict Wong <bennydictwong@gmail.com>
Signed-off-by: Benedict Wong <bennydictwong@gmail.com>
Signed-off-by: Benedict Wong <bennydictwong@gmail.com>
Signed-off-by: Benedict Wong <bennydictwong@gmail.com>
…ke a single string Signed-off-by: Benedict Wong <bennydictwong@gmail.com>
Signed-off-by: Benedict Wong <bennydictwong@gmail.com>
Signed-off-by: Benedict Wong <bennydictwong@gmail.com>
Signed-off-by: Benedict Wong <bennydictwong@gmail.com>
Signed-off-by: Benedict Wong <bennydictwong@gmail.com>
Signed-off-by: Benedict Wong <bennydictwong@gmail.com>
Signed-off-by: Benedict Wong <bennydictwong@gmail.com>
Signed-off-by: Benedict Wong <bennydictwong@gmail.com>
Signed-off-by: Benedict Wong <bennydictwong@gmail.com>
Signed-off-by: Benedict Wong <bennydictwong@gmail.com>
Signed-off-by: Benedict Wong <bennydictwong@gmail.com>
Added patch consolidation, rebuilt OT to use streaming
ensure no connections between components rework of rabbitmq connections to separate them from websocket connections restructure datahandling to not be tied to websockets
…fied across severs switch from ECDSA to RSA keys refactor loading to come from config
Signed-off-by: Benedict Wong <bennydictwong@gmail.com>
ObsessiveOrange
approved these changes
Apr 3, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wow this was a lot, haha