refactor: clarify API naming, suppress interop/URL-shape rules (CA1716, CA1721, CA1724, CA1725, CA1054, CA1056, CA1003) - #161
Merged
Conversation
DeepDiver1975
commented
Aug 30, 2026
Collaborator
- CA1716 (12): suppressed app-wide in .editorconfig (root section, alongside CA2007) — cross-language/VB interop rule with no value in this C#-only app; idiotic renaming any of interface members Get/Stop/Operator, params set/to, or the App.Shared namespace root.
- CA1725 (1): IncidentReportDocument.Compose param renamed document -> container to match IDocument.Compose.
- CA1721 (1): AppPaths.AppDataDir renamed to Root (property vs GetAppDataDir clash; internal to the class).
- CA1724 (1): App class in LageBuch.App.Shared suppressed — collision with LageBuch.App namespace is inherent to the app name.
- CA1003 (4): IIncidentSession.Changed and RemoteIncidentSession Disconnected/Reconnected/Ended suppressed — in-process fire-and-forget events whose Action type matches the pervasive convention (GoHomeRequested etc.).
- CA1054/CA1056 (6): string URLs suppressed with justification in IFileDialogService.OpenUrlAsync, Link.Link/Link.Url, LinkRow ctor, AboutViewModel.RepositoryUrl, and the LinksViewModelTests theory — URLs are free-form display/launch strings (persisted master data) and System.Uri would reject non-parseable values.
- Verification: all seven rules at 0 under AnalysisMode=All, zero errors, no change in any other rule vs main baseline; full suite 801 passed / 1 skipped.
…1716, CA1721, CA1724, CA1725, CA1054, CA1056, CA1003) Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
DeepDiver1975
force-pushed
the
fix/analyzer-naming-apis
branch
from
August 30, 2026 21:25
7500033 to
b9a0e21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.