Skip to content

refactor: clarify API naming, suppress interop/URL-shape rules (CA1716, CA1721, CA1724, CA1725, CA1054, CA1056, CA1003) - #161

Merged
DeepDiver1975 merged 1 commit into
mainfrom
fix/analyzer-naming-apis
Aug 30, 2026
Merged

refactor: clarify API naming, suppress interop/URL-shape rules (CA1716, CA1721, CA1724, CA1725, CA1054, CA1056, CA1003)#161
DeepDiver1975 merged 1 commit into
mainfrom
fix/analyzer-naming-apis

Conversation

@DeepDiver1975

Copy link
Copy Markdown
Collaborator
  • CA1716 (12): suppressed app-wide in .editorconfig (root section, alongside CA2007) — cross-language/VB interop rule with no value in this C#-only app; idiotic renaming any of interface members Get/Stop/Operator, params set/to, or the App.Shared namespace root.
  • CA1725 (1): IncidentReportDocument.Compose param renamed document -> container to match IDocument.Compose.
  • CA1721 (1): AppPaths.AppDataDir renamed to Root (property vs GetAppDataDir clash; internal to the class).
  • CA1724 (1): App class in LageBuch.App.Shared suppressed — collision with LageBuch.App namespace is inherent to the app name.
  • CA1003 (4): IIncidentSession.Changed and RemoteIncidentSession Disconnected/Reconnected/Ended suppressed — in-process fire-and-forget events whose Action type matches the pervasive convention (GoHomeRequested etc.).
  • CA1054/CA1056 (6): string URLs suppressed with justification in IFileDialogService.OpenUrlAsync, Link.Link/Link.Url, LinkRow ctor, AboutViewModel.RepositoryUrl, and the LinksViewModelTests theory — URLs are free-form display/launch strings (persisted master data) and System.Uri would reject non-parseable values.
  • Verification: all seven rules at 0 under AnalysisMode=All, zero errors, no change in any other rule vs main baseline; full suite 801 passed / 1 skipped.

…1716, CA1721, CA1724, CA1725, CA1054, CA1056, CA1003)

Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
@DeepDiver1975
DeepDiver1975 force-pushed the fix/analyzer-naming-apis branch from 7500033 to b9a0e21 Compare August 30, 2026 21:25
@DeepDiver1975
DeepDiver1975 merged commit af9d7be into main Aug 30, 2026
3 of 4 checks passed
@DeepDiver1975
DeepDiver1975 deleted the fix/analyzer-naming-apis branch August 30, 2026 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant