refactor: remove unused Stammdaten categories - #173
Merged
Conversation
Status, Equipment, Districts, Streets, Einsatzarten, and the settings' PressureControlIntervalMinutes were editable and persisted in the Stammdaten editor but never actually read by any ViewModel, view, or domain logic elsewhere in the app. ScbaViewModel derives its control interval from AgtMaxDurationMinutes / 3 instead, so the stored value was silently ignored. Remove the dead schema, persistence, editor sections, and settings field end-to-end. Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
Sections were added in ad-hoc insertion order, making the left-hand category list harder to scan. Keep Einstellungen pinned first since it holds numeric defaults rather than a data category, and sort the remaining ten sections alphabetically below it. Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
Collaborator
Author
|
Added one more commit: sort the Stammdaten editor's navigation list. "Einstellungen" stays pinned first (numeric defaults, not a data category); the other 10 sections now sort alphabetically instead of ad-hoc insertion order. Updated screenshot for the sorted nav — file path for pasting: Full solution build + test suite green (811 tests, Android target excluded — no Android SDK in this environment, unrelated). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ScbaViewModelderives its control interval fromAgtMaxDurationMinutes / 3instead of reading the stored value).MasterDataSet/IncidentSettingsrecord fields (and the now-unusedStreettype), JSON parse/serialize, SQLite schema/read/write, the Stammdaten editor's sections and settings field (view model + XAML), and the corresponding docs/example-data mentions.Screenshots
This changes the Stammdaten editor's UI. Before/after screenshots of the editor
(same fixture, headless Skia harness) are ready locally — see the PR comment /
chat for file paths; paste them here.
Test plan
dotnet build— all non-Android projects build clean (Android target fails locally only due to no Android SDK installed in this environment, unrelated to this change)dotnet test— full suite green: 218+87+24+54+299+90+6+33 tests passed across all projects, 0 failuresdocs/master-data.example.jsonagainst the updated schema for parity🤖 Generated with Claude Code
https://claude.ai/code/session_01UreNDccLAQTXPm5snDpugv