refactor(ui): tighten workspace header and move sharing onto the status line - #174
Merged
Conversation
…us line The Einsatz identity block wasted vertical space: a full row for "im Netzwerk freigeben", generous padding, and 14px inter-row spacing pushed the actual content (ETB, checklists, etc.) further down than needed. Tighten the header's padding/spacing, and replace the full-width sharing button with a compact icon button on the status line — its icon swaps between a share glyph and a close (X) glyph based on IsSharing, and once active the address/PIN render inline next to the status pill instead of on their own row. Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
The label added no information beyond what the hero text and the whole identity block already convey, and cost a row of vertical space above it. Removing it collapses the identity grid to a single row. Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
Collaborator
Author
|
Before: After: |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IsSharing. Once sharing starts, the reachable-at address and PIN render inline on that same line instead of their own row.CanHost,IsSharing,ShareStatus,SharePin,ShareButtonText,ToggleSharingCommand).Test plan
dotnet builddotnet test tests/LageBuch.Acceptance.Tests— 89 passed / 1 skipped (pre-existing skip), includingLayoutAlignmentTests,HeaderHeroTests,SharePanelRenderTests,ReminderFontTestsWorkspaceRenderHelper+Window.CaptureRenderedFrame()) confirming the layout and both icon states