fix(app): flame app icon in place of the cross pattée - #37
Merged
Conversation
The placeholder from #35 read as a medieval knight's banner rather than a fire-service mark. Replace it with a flame in the app's signal-red/amber on the same dark tile -- the most universal "fire" symbol and the cleanest at small sizes. Only the three committed assets change (icon.svg + regenerated icon-1024.png and the multi-size icon.ico). Every installer consumer takes the icon path as a parameter from the release workflow, and the macOS .icns is derived on the runner from the PNG, so nothing else needs touching. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The placeholder icon from #35/#36 read as a medieval knight's banner rather than a fire-service
mark. Replaced with a flame in the app's own signal-red/amber on the same dark tile — the most
universal "fire" symbol and the cleanest at small sizes.
Chosen from five fire-brigade concepts (flame, helmet, extinguisher, beacon, flame-on-clipboard).
Scope
Only the three committed assets change:
icon.svgand the regeneratedicon-1024.png+multi-size
icon.ico. Every installer consumer takes the icon path as a workflow parameter (WiXIconFile, the.deb/.dmgPNG argument), and the macOS.icnsis derived on the runner from thePNG — so no workflow,
.wxs, or script edits.Verification
dotnet build src/Feuerwehr.App -c Releasesucceeds — this embedsicon.ico, so a malformed icowould fail here.
icotool -lconfirms all seven sizes (16–256).🤖 Generated with Claude Code