Pr 1038 - #1039
Closed
luiox wants to merge 3 commits into
Closed
Conversation
Add a Plugins menu and plugin manager panel for listing installed plugins and enabling/disabling, installing, and uninstalling them. - PluginManagerPane: scans the plugin + disabled directories, renders plugin metadata, and drives install/enable/disable/uninstall via synchronous core operations (installFrom / applyEnabled / applyUninstall). - PluginManagerWindow + WindowManager WIN_PLUGINS registration. - PluginMenu: opens the manager panel, plus dev-guide and template links. - Translations for en_US and zh_CN. - PluginManagerPaneTest covering scan/enable/disable/install/uninstall with real sample plugin jars.
- Add @afterall stopFx() with Platform.exit() to shut down JavaFX after tests complete, preventing JVM from hanging - Add @AfterEach cleanup() to delete temporary test directories - Track home path as field for cleanup - Wrap ErrorDialogs.show() calls with FxThreadUtil.run() to avoid IllegalStateException from background threads - Remove redundant refresh() call in dependant cancel path
The test previously required JavaFX (Platform.startup/Platform.runLater) to construct PluginManagerPane, which caused CI timeout under JUnit 5 parallel execution (all test classes share one FX thread). Added a package-private constructor PluginManagerPane(manager, dirs, true) that skips all UI initialization. The test now constructs the pane directly without JavaFX, exercising only the synchronous business logic (scanPluginFiles, applyEnabled, installFrom, applyUninstall). Also already applied: ErrorDialogs.show() wrapped via FxThreadUtil.run() to run on FX thread; @AfterEach temp dir cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new
What's fixed