Conversation
…s icons Closing the main window now hides it (standard macOS behavior) and a RunEvent::Reopen handler restores it from the Dock. Tray removal goes through the app's tray registry (remove_tray_by_id) instead of dropping a handle, which leaked one icon per off/on cycle. Adds set_dock_visible for the new hide-Dock-icon setting.
… scrollable history - Appearance (System/Light/Dark): resolved theme stamped as data-theme on <html>; dark palette re-keyed off it. Both windows restyle live (matchMedia for System, storage event for the popover). - Hide Dock icon toggle, gated on the menu bar icon being on; turning the tray off forces the Dock icon back. - Profiles: DRY-RUN PREVIEW panel is now a persistent fixture with a placeholder; history panel capped at 260px and scrolls. - Beta/Stable channel switch re-runs the update check immediately; update hint uses the renamed openwith-gui cask.
Switching the activation policy to Accessory deactivates the app and orders its windows out, so the toggle appeared to close the main window. Re-show and refocus it after the switch when it was visible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the two serious GUI bugs found in real v0.5.1 use, closes the Profiles/theme polish gaps, ships the last Phase-3 item (hide Dock icon), and untangles the CLI-vs-GUI Homebrew naming.
Fixes
RunEvent::Reopen) or the popover's "Open main window". Previously the window was unrecoverable until relaunch.remove_tray_by_id(the builder registers a clone in the app's resources table, so dropping our handle never removed the icon).Features
data-themeon<html>; both windows restyle live (matchMedia for System,storageevent for the popover).Changes
openwith→openwith-guiin the tap (already pushed); README restructured into explicit CLI vs GUI install tracks; release templates + steps updated; in-app update hint uses the new cask name.Validation
cargo fmt --check,cargo check,cargo clippy --all-targets --all-features -- -D warnings,cargo test(24 passed),npm run build— all green.Release plan
Tag is held. A .dmg is built from this branch for soak testing; tag/release/formula/cask bumps happen only after that passes.