scte35, psi: guard bounds before trusting pointer/length fields - #185
Open
ChrisJr404 wants to merge 1 commit into
Open
scte35, psi: guard bounds before trusting pointer/length fields#185ChrisJr404 wants to merge 1 commit into
ChrisJr404 wants to merge 1 commit into
Conversation
NewSCTE35 and NewPMT both index into the input before checking it's long enough. Empty input panics in psi.PointerField (reads data[0]), and a PMT section length larger than the buffer slices past the end. Bounds-check first and return the existing error types instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NewSCTE35 and NewPMT index into their input before checking it fits, so malformed data panics instead of returning an error.
Two failure modes, both found by fuzzing:
Valid input decodes the same as before. Added TestNewSCTE35Truncated and TestNewPMTTruncated with the reproduced inputs (panic before, error after). go build/vet/test all pass.