Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 25 additions & 4 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,12 @@ tracing = "0.1.40"
tracing-subscriber = { version = "0.3.18", features = ["env-filter", "fmt"] }
serde = { version = "1", features = ["derive"] }
toml = "0.8"
# git rev (not crates.io 0.1.0) so this and `comline-codelib-gen` share one
# git rev (not crates.io) so this and the `comline-codegen*` crates share one
# `comline-core` in the tree. Local dev: see .cargo/config.
comline-core = { git = "https://github.com/ComlineProject/core", rev = "aa84d970d3295df59cc3e620bdb71bf96382f97b" }
comline-codelib-gen = { git = "https://github.com/ComlineProject/generation", rev = "c1f86392f50f60b5df3d648b158426628d8ed802" }
comline-codegen = { git = "https://github.com/ComlineProject/generation", rev = "8ff03d7a8ca5f5e65befcb52728863b254eb4128" }
comline-codegen-rust = { git = "https://github.com/ComlineProject/generation", rev = "8ff03d7a8ca5f5e65befcb52728863b254eb4128" }
comline-codegen-typescript = { git = "https://github.com/ComlineProject/generation", rev = "8ff03d7a8ca5f5e65befcb52728863b254eb4128" }

[target.'cfg(unix)'.dependencies]
libc = "0.2"
Expand Down
5 changes: 2 additions & 3 deletions src/commands/clean.rs
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ pub(crate) fn generated_files(work_dir: &Path) -> Vec<PathBuf> {
return Vec::new();
};

let registry = super::generate::generator_registry();
let mut files = Vec::new();
for t in &targets {
// A dedicated output directory: remove it wholesale (stale files too).
Expand All @@ -102,9 +103,7 @@ pub(crate) fn generated_files(work_dir: &Path) -> Vec<PathBuf> {
// Output lands among the sources — only touch the exact files. This
// covers the single-version (`latest`) case; a multi-version tree lives
// under a dedicated `out` dir and is removed by the branch above.
let Some((_, ext)) =
comline_codelib_gen::code_gen::find_generator(&t.language, &t.lang_version)
else {
let Some((_, ext)) = registry.find(&t.language, &t.lang_version) else {
continue;
};
for schema_ctx in &context.schema_contexts {
Expand Down
15 changes: 13 additions & 2 deletions src/commands/generate.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
use std::collections::HashMap;
use std::path::Path;

use comline_codelib_gen::code_gen::{self, GenRequest, Mode, PackageMeta};
use comline_codegen::{GenRequest, Mode, PackageMeta, Registry};
use comline_core::package::build::{self, cas::ObjectStore};
use comline_core::package::config::ir::frozen::FrozenUnit as ConfigUnit;
use comline_core::schema::idl::constants::SCHEMA_EXTENSION;
Expand All @@ -23,6 +23,15 @@ use crate::commands::{core_err, ensure_project};
use crate::gen_config::{self, ComlineToml, DeclaredLang, Overrides, VersionSpec};
use crate::{history, ui, watch};

/// The generator registry, composed from the per-language `comline-codegen-*`
/// crates this CLI was built with. (Feature-gating the set is rollout step 6.)
pub(crate) fn generator_registry() -> Registry {
let mut registry = Registry::new();
comline_codegen_rust::register(&mut registry);
comline_codegen_typescript::register(&mut registry);
registry
}

pub fn run(work_dir: &Path, overrides: &Overrides, watching: bool) -> Result<()> {
ensure_project(work_dir)?;

Expand Down Expand Up @@ -93,6 +102,8 @@ fn generate_once(work_dir: &Path, overrides: &Overrides) -> Result<()> {

let targets = gen_config::resolve(&cfg, &declared, work_dir, overrides)?;

let registry = generator_registry();

let mut written = 0usize;
for t in &targets {
let mode = match t.mode.as_str() {
Expand All @@ -106,7 +117,7 @@ fn generate_once(work_dir: &Path, overrides: &Overrides) -> Result<()> {
}
};

let Some((generator, ext)) = code_gen::find_generator(&t.language, &t.lang_version) else {
let Some((generator, ext)) = registry.find(&t.language, &t.lang_version) else {
return Err(miette!(
"no generator for `{}` (version `{}`)",
t.language,
Expand Down
Loading