feat: feature-gate the generator crates (rollout step 6) - #22
Merged
Conversation
comline-codegen-rust / -typescript become optional deps behind gen-rust / gen-typescript features (both default). generator_registry() guards each register() with #[cfg(feature = ...)]. A build with --no-default-features --features gen-rust drops the typescript crate and its dep tree entirely. Default build + 36 + 2 tests pass; rust-only build compiles; fmt clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI composes its generator
Registryfrom per-language crates that are now in their own repos — this makes each opt-out.comline-codegen-rust/comline-codegen-typescript→optional = true, behindgen-rust/gen-typescriptfeatures (both indefault).generator_registry()guards eachregister()with#[cfg(feature = …)].cargo build --no-default-features --features gen-rustdrops the TypeScript generator crate and its whole dependency tree. A third-partycomline-codegen-<lang>slots in the same way.Local: default build + 36 + 2 tests pass; rust-only build compiles;
cargo fmt --checkclean.