test: end-to-end handshake — driver uses ChatClient::connect / Dispatcher::serve - #25
Merged
Conversation
…cher::serve Bumps comline-codegen-rust to comline-rust main (through #6, the handshake codegen) and switches the end_to_end driver from `Client::new` / `Server::serve` to the generated `ChatClient::connect(transport, MsgPack)` and `ChatDispatcher(svc).serve(&mut transport, MsgPack)` helpers — so the connection handshake (IR_HASH + format name, exchanged + checked) runs through the whole schema -> CLI -> compile -> run pipeline. Also picks up #5 (@timeout_ms codegen).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to comline-rust#6 (handshake codegen).
comline-codegen-rustto comline-rustmain(through feature: richer generate output — paren path, source→output, labelled target #6; also picks up feature: show the working path in output; add --plain mode #5,@timeout_mscodegen).end_to_enddriver moves fromClient::new/Server::serveto the generated helpers:ChatClient::connect(transport, MsgPack)andChatDispatcher(svc).serve(&mut transport, MsgPack)— so the connection handshake (IR_HASH+ format name, exchanged andchecked) runs through the whole.comline→comline generate→ compile → run pipeline, alongside the request/response call, the typed raised error, and the one-way notify.cargo testgreen (37 integration + 2 unit);cargo fmt --checkclean.