Skip to content

feat(rust): emit the canonical IR_HASH from comline-core #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kinflou merged 2 commits into from
Sep 2, 2026
Merged

feat(rust): emit the canonical IR_HASH from comline-core #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17c7b23
feat(rust): emit the canonical IR_HASH from comline-core
Sep 2, 2026
f29f651
chore: bump comline-codegen to generation d901db4 (matches core 50c17cc)
Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions codegen/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ license = "GPL-3.0-only"
# repository structure — no crates.io publishing at this stage). Pinned to the
# same generation rev `comline-typescript` uses, so a CLI build has one
# `comline-codegen`. Local iteration: add a `[patch]` onto a sibling checkout.
comline-codegen = { git = "https://github.com/ComlineProject/generation", rev = "c70336dcc9485cea2c99b0f1db3789e420deaeda" }
comline-core = { git = "https://github.com/ComlineProject/core", rev = "47ac5f10a36b587d14d1b9672fba65d8f3712962" }
comline-codegen = { git = "https://github.com/ComlineProject/generation", rev = "d901db42d094ea9e2f59a310e6e885767abcae6b" }
comline-core = { git = "https://github.com/ComlineProject/core", rev = "50c17cc740676416e945582dd6e2547e8535ac03" }

eyre = "0.6.8"

Expand Down
21 changes: 4 additions & 17 deletions codegen/src/generator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ use std::collections::HashMap;
use std::path::PathBuf;

use comline_core::schema::ir::compiler::interpreted::kind_search::KindValue;
use comline_core::schema::ir::frozen::schema_ir_hash;
use comline_core::schema::ir::frozen::unit::{FrozenArgument, FrozenUnit};

use eyre::{bail, Result};
Expand Down Expand Up @@ -173,10 +174,10 @@ fn schema_source(units: &[FrozenUnit], default_framing: Option<&str>) -> String

if has_protocol {
output.push_str(&format!(
"/// Fingerprint of the frozen IR this file was generated from — the two\n\
/// ends of a connection [`Handshake`] must agree on it.\n\
"/// Canonical digest of the frozen IR this file was generated from — the\n\
/// two ends of a connection [`Handshake`] must agree on it.\n\
pub const IR_HASH: u64 = {:#018x};\n\n",
ir_hash(units)
schema_ir_hash(units)
));
}

Expand Down Expand Up @@ -212,20 +213,6 @@ fn schema_source(units: &[FrozenUnit], default_framing: Option<&str>) -> String
output
}

/// A deterministic fingerprint of the schema's frozen units — FNV-1a over their
/// `Debug` form. Stable for a given generator version; a generator bump changes
/// it, which is correct (different codegen ⇒ a new handshake identity). A
/// canonical cross-language hash from `core`'s CAS, threaded through
/// `GenRequest`, is the eventual form.
fn ir_hash(units: &[FrozenUnit]) -> u64 {
let mut h: u64 = 0xcbf2_9ce4_8422_2325;
for b in format!("{units:?}").as_bytes() {
h ^= u64::from(*b);
h = h.wrapping_mul(0x0000_0100_0000_01b3);
}
h
}

// ── data types ─────────────────────────────────────────────────────────────

fn field_lines(fields: &[FrozenUnit]) -> String {
Expand Down
Loading