chore: drop codelib_gen — codegen lives in generation now - #41
Merged
Conversation
The `rust` generator was ported verbatim into `ComlineProject/generation` (`comline-codelib-gen`, de-rot G1a) and the CLI is the composition root. `core` is the compiler + IR; it no longer ships a generator. - remove `src/codelib_gen/` (`mod.rs`, `rust.rs`) and `pub mod codelib_gen;` - remove `tests/codelib_gen/` (ported to generation) and its `mod` line `cargo test`: green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
rustgenerator was ported verbatim intoComlineProject/generation(comline-codelib-gen, de-rot G1a — generation#3, merged) and the CLI is the composition root.coreis the compiler + IR; it no longer ships a generator.src/codelib_gen/(mod.rs,rust.rs) andpub mod codelib_gen;fromlib.rs.tests/codelib_gen/(ported to generation) and itsmodline.cargo test: green (233 + suites, 0 failed).Coordination
Pairs with a
cliPR that repointsfind_generatorfromcomline_core::codelib_gentocomline_codelib_gen.clicurrently builds against publishedcomline-core 0.1.0(which still hascodelib_gen), so nothing breaks in the gap — thecliPR moves it onto acoregit rev alongside thecomline-codelib-gengit dep. Merge order between the two doesn't matter.Design: design/generation.md → G1b.