chore: bump comline-core to 47ac5f1 (throws ordinals, Function.parameters, KindValue::Unit) - #12
Merged
Merged
Conversation
added 2 commits
September 1, 2026 23:49
…ters, KindValue::Unit)
codegen already bumped (previous commit). conformance's own comline-core pin, plus its comline-codegen-rust / comline-codegen-typescript dev-deps, now point at those repos' matching bumps (comline-rust#1, merged; comline-typescript#1). The hand-built fixtures needed the same shape update as every other FrozenUnit::Function/Error literal in this rev bump: drop synchronous, add parameters: vec![], throws as ordinals (added an Error unit for the 'protocol' fixture's NotFound so its ordinal 0 has a home). Neither generator reads Error/throws yet, so the goldens are unchanged -- corpus_matches_golden passes without re-blessing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coordinated bump:
comline-core#46 (dropFunction.synchronous, addFunction.parameters,KindValue::Unit) + #47 (throws: Vec<u16>— schema-global error ordinals).codegen'scomline-corepin →47ac5f1.conformance's owncomline-corepin →47ac5f1, and its dev-deps oncomline-codegen-rust/comline-codegen-typescript→ their matching bumps (comline-rust#1, merged; comline-typescript#1) — otherwise the workspace has twocomline-cores.conformance/src/lib.rsget the same shape update as every otherFrozenUnitliteral in this bump: dropsynchronous, addparameters: vec![],throwsas ordinals (added anErrorunit for theprotocolfixture'sNotFoundso its ordinal0has a home, mirroring what a real schema would freeze).Neither generator reads
Error/throwsyet (known gap,conformance/README.md), so the goldens are unchanged —corpus_matches_goldenpasses without re-blessing.Verified
cargo test --workspacegreen — codegen (0), conformance (1 + corpus), no duplicate-comline-coreerrors.Depends on
comline-typescript#1 merging first (referenced here by commit, not yet on
main).