chore(conformance): re-bless for comline-rust protocol codegen - #13
Merged
Conversation
Bumps the dev-dep on comline-codegen-rust to comline-rust#2 (the RPC-shape
generator) and comline-codegen-typescript to its merged rev, then
re-blesses the goldens.
- protocol/rust.rs: the full RPC shape now -- params structs, per-fn +
union error enums (NotFound at ordinal 0), the Service trait, the
Dispatch impl, the Client stub.
- optional_and_arrays/rust.rs, type_refs/rust.rs: `optional` fields now
render `Option<T>` -- the old generator dropped the flag. (A known
conformance gap, fixed incidentally by the field-rendering rewrite.)
- import line reordered to `{Deserialize, Serialize}` across the rust
goldens.
typescript goldens unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to comline-rust#2 (the RPC-shape generator, merged).
comline-codegen-rust→ comline-rustmain(protocol codegen),comline-codegen-typescript→ its merged rev.protocol/rust.rs: the full RPC shape now — params structs, per-fn + union error enums (NotFoundat ordinal 0), theServicetrait, theDispatchimpl, theClientstub.optional_and_arrays/rust.rs,type_refs/rust.rs:optionalfields now renderOption<T>— the old generator dropped the flag entirely. A known conformance gap, fixed incidentally by the field-rendering rewrite.{Deserialize, Serialize}across the rust goldens.TypeScript goldens unchanged.
cargo test --workspacegreen (corpus_matches_goldenpasses against the re-blessed goldens).