feat: semantic diagnostics from comline-core's validation pass - #2
Merged
Conversation
Diagnostics were syntax-only. Once a document parses cleanly, the server
now interprets it (`IncrementalInterpreter::from_declarations`) and runs
`comline_core::schema::ir::validation::validate` — surfacing undefined
type references, duplicate declarations, and the rest of the checks
`comline build` runs, placed by each `ValidationError`'s byte span.
- analysis/diagnostics.rs: `validation_diagnostics` + `all_diagnostics`
(parse errors, then validation only if the tree is well-formed).
- backend.rs: `parse_and_publish_diagnostics` calls `all_diagnostics`.
- tests: undefined type, duplicate declaration, clean schema, and
"malformed tree ⇒ validation skipped, no panic".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diagnostics were syntax-only. Once a document parses cleanly, the server now interprets it (
IncrementalInterpreter::from_declarations) and runscomline_core::schema::ir::validation::validate— surfacing undefined type references, duplicate declarations, and the rest of the checkscomline buildruns, each placed by itsValidationError's byte span.analysis/diagnostics.rs:validation_diagnostics+all_diagnostics(parse errors first; validation only when the tree is well-formed).backend.rs:parse_and_publish_diagnosticscallsall_diagnostics.Now the editor shows the same errors as the CLI, live.