fix(completion): no suggestions inside comments or strings - #4
Merged
Conversation
Completion offered keywords / primitives / types regardless of cursor context — including inside `///` docstrings, `//` comments and string literals, where the text isn't Comline. Add a one-line scan (`in_comment_or_string`) and bail early. Fixes the playground editor popping `use` / `bool` while typing a docstring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_completionsreturned keywords / primitives / types for any cursor position — including inside///docstrings,//comments and string literals, where the text isn't Comline (visible as the playground editor poppinguse/boolmid-docstring).Adds
in_comment_or_string(source, offset)— a one-line prefix scan (Comline has no block comments and strings don't span lines) — and returns[]early when the cursor is in either. A//inside a string doesn't start a comment.Shared fix:
comline-lsp(→ VS Code) and the playground both get it. 47 unit + 2 e2e + 4 integration green; wasm build unaffected.