Anchor connection wires at the port dots - #43
Merged
Conversation
`drawWires` ran box-centre to box-centre, so the line passed under the instance rows and never touched the `.node-port` dots it's supposed to connect. Anchor each end at the port's real (transform-aware) rect centre, in the same coordinate space `canvasPoint` uses — the drag-to-connect line starts there too. Falls back to the row centre in the embed view, which has no port.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wire between two instances was drawn box-centre → box-centre, so it ran
under the node rows and stopped nowhere near the
.node-portdots it'smeant to attach to (see the report — the line floats past both ports).
portAnchor(instanceId)now returns the port dot's real centre viagetBoundingClientRect(so thetop: 50%; translateY(-50%)is accountedfor), converted to the same canvas space
canvasPointproduces — which iswhere nodes are positioned, so the endpoints land exactly on the dots.
startConnectDrag's rubber-band line starts there too. Embed view (noport) falls back to the row centre.
yarn test(20) andyarn buildpass. No coordinate assertions in thetests to update.