Fix frames column alignment - #49
Merged
Merged
Conversation
The header (`font-size: 0.6rem`) and the rows (`0.72rem`) each sized their own `3ch` / `minmax(_, auto)` tracks, so the columns drifted. Every track is now rem or a single shared `1fr` (fn) — font-size- and content-independent, so the header lines up with the rows. `direction` is a fixed 10rem (ellipsis past that); `fn` takes the slack.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The header from #48 didn't line up with the rows: the header is
font-size: 0.6remand the rows0.72rem, and both had3chandminmax(_, auto)tracks —chis font-size-relative andautosizes toeach grid's own text, so the two grids resolved different column widths.
--frame-gridis now all rem plus one shared1fr(thefncolumn) —nothing content- or font-size-dependent, so the header and every row use
identical tracks.
directionis a fixed 10rem (ellipsis past that).24 tests + build green.