Align the frames header with the rows - #51
Merged
Conversation
The `.sim-frames-list` had `0.4rem` side padding but the column header didn't, so every column sat 0.4rem left of its label. Drop the list's side padding (cells carry their own now) — header and rows share the same left edge. Widen the `#` / `kind` / `conn` tracks so `001` and `handshake` stop truncating to `0…` now that each cell spends 1rem on padding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #50 the column header still sat 0.4rem left of the data, and
#/kindtruncated to0…/handshak…..sim-frames-listhad0 0.4rem 0.4rempadding — the rows were inset bythat
0.4rem, the header wasn't. Dropped the side padding (cells carrytheir own now); header and rows share one left edge.
1remon horizontal padding, so the old2rem#track and
5remkindtrack were too tight → widened the grid(
3rem 10rem 5.5rem 1fr 5rem 4rem, conn8rem).24 tests + build green.