Switch from pnpm to Yarn (Berry 4) - #3
Merged
Merged
Conversation
- `.yarnrc.yml` — `nodeLinker: node-modules`, the committed Yarn 4 release, `approvedGitRepositories` + `enableScripts` for the `comline-simulator` git dep, `checksumBehavior: update` (its WASM build isn't byte-reproducible). - `pnpm-lock.yaml` → `yarn.lock`; `pnpm.overrides` → `resolutions`; drop `.npmrc` (`engine-strict` has no Yarn equivalent); `test` script uses `yarn`. - `deploy.yml` — no more `pnpm/action-setup`; `yarn install` (with `COMLINE_SIMULATOR_SCRIPT=0`, the tutorial only needs the lean sim) / `yarn build`; `cache: yarn`. - Repin `comline-simulator` to simulator@eff27ce (#18 — Yarn runs `prepack`, which that adds). `yarn check` / `yarn build` / `yarn test:unit` all pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardises the web projects on Yarn 4 (the playground is doing the same in
ComlineProject/playground#42).
Setup
.yarnrc.yml—nodeLinker: node-modules(PnP would need plugins forVite's wasm
?url+ thecomline-simulator/pkg-script/…deep import);approvedGitRepositories+enableScripts: trueso the git-dep sim enginecan fetch and build;
checksumBehavior: updatebecause that WASM buildisn't byte-reproducible across machines. Yarn 4.18 committed under
.yarn/releases/.pnpm-lock.yaml→yarn.lock;pnpm.overrides→resolutions;.npmrcdropped.
deploy.yml— dropspnpm/action-setup;yarn install(withCOMLINE_SIMULATOR_SCRIPT=0— the tutorial only uses the leanpkg/) /yarn build;cache: yarn.comline-simulatorrepinned toeff27ce(simulator#18, which teaches thebuild hook to also run as
prepack— Yarn Berry uses that for git deps).Checks
yarn check(svelte-check 0/0),yarn build, andyarn test:unitpasslocally.