fix(pumpkin-propagators): Make integer multiplication bounds(R) consistent - #517
Open
maartenflippo wants to merge 13 commits into
Open
fix(pumpkin-propagators): Make integer multiplication bounds(R) consistent#517maartenflippo wants to merge 13 commits into
maartenflippo wants to merge 13 commits into
Conversation
ImkoMarijnissen
previously requested changes
Jul 27, 2026
ImkoMarijnissen
previously requested changes
Jul 29, 2026
maartenflippo
force-pushed
the
fix/bounds-consistency-multiplication
branch
from
July 29, 2026 19:08
5a1e617 to
dfae0bf
Compare
ImkoMarijnissen
approved these changes
Jul 30, 2026
ImkoMarijnissen
left a comment
ImkoMarijnissen
left a comment
Contributor
There was a problem hiding this comment.
Some small changes, but I think it can be merged
Comment on lines
+137
to
+138
| /// In order, for each bound it is dropped if, when relaxing it, the `bound_fn` still justifies the | ||
| /// propagation we are explaining. Every bound that is deemed necessary is appended to `buffer`. |
Contributor
There was a problem hiding this comment.
How about more something like this?
It is checked (in order) whether removing the bound from the explanation for the propagation still leads to a valid explanation (using
bound_fnto calculate the possible bounds). The predicates necessary for a valid explanation are added tobuffer.Note - This leads to a subset minimal explanation (i.e., no element can be removed for it to still be a valid explanation), and not a cardinality minimum explanation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actually do the case-distinction to finally get our multiplication to be bounds(R) consistent.