test(flow): assert the node registry for real, now that it has an HTTP surface - #2178
Merged
Merged
Conversation
…P surface This assertion skipped, because OpenRegister exposed no palette endpoint at all — FlowNodeRegistry::palette() was in-process only, so nothing over HTTP could enumerate registered node types. #2177 added /api/flow/node-catalog, so the check can be real. It immediately earned its keep: openconnector's leaves were silently failing to register on a clean install (a class_exists load-order guard evaluated during register(), openconnector#1076), and no test in either repo could see it. With the endpoint asserted, that regression cannot come back unnoticed. 4/4 against an isolated NC 34 + Postgres instance on merged development.
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 174/174 | |||
| npm | ✅ | ✅ 555/555 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-07-28 08:14 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This assertion skipped, because OpenRegister exposed no palette endpoint at all —
FlowNodeRegistry::palette()was in-process only, so nothing over HTTP could enumerate registered node types. #2177 added/api/flow/node-catalog, so the check can be real.It immediately earned its keep: openconnector's leaves were silently failing to register on a clean install (a
class_existsload-order guard evaluated duringregister()— ConductionNL/openconnector#1076), and no test in either repo could see it. With the endpoint asserted, that regression cannot come back unnoticed.Verified against an isolated NC 34 + Postgres instance running merged
development.