Skip to content

Update deprecated ghcr.io image reference to public.ecr.aws - #152

Open
luisina-santos wants to merge 1 commit into
mainfrom
luisinasantos/fix-ghcr-image-references
Open

Update deprecated ghcr.io image reference to public.ecr.aws#152
luisina-santos wants to merge 1 commit into
mainfrom
luisinasantos/fix-ghcr-image-references

Conversation

@luisina-santos

Copy link
Copy Markdown
Contributor

Summary

  • README.md referenced this connector's image via ghcr.io/conductorone/baton-aws:latest; container images are now published to public.ecr.aws/conductorone/baton-aws:latest instead.
  • Only this connector's own image reference was updated.
  • Related audit: CXH-2418.

Test plan

  • Verified public.ecr.aws/conductorone/baton-aws:latest resolves (manifest exists) before opening this PR.
  • Diff reviewed — only the image domain changed.

🤖 Generated with Claude Code

README.md referenced this connector's image via ghcr.io/conductorone;
container images are now published to public.ecr.aws/conductorone
instead. Only this connector's own image reference was updated.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Comment thread README.md
```
docker run --rm -v $(pwd):/out -e BATON_GLOBAL_SECRET_ACCESS_KEY=awsSecretAccessKey -e BATON_GLOBAL_ACCESS_KEY_ID=awsAccessKey ghcr.io/conductorone/baton-aws:latest -f "/out/sync.c1z"
docker run --rm -v $(pwd):/out -e BATON_GLOBAL_SECRET_ACCESS_KEY=awsSecretAccessKey -e BATON_GLOBAL_ACCESS_KEY_ID=awsAccessKey public.ecr.aws/conductorone/baton-aws:latest -f "/out/sync.c1z"
docker run --rm -v $(pwd):/out ghcr.io/conductorone/baton:latest -f "/out/sync.c1z" resources

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Suggestion: The adjacent baton CLI image on this line still points at ghcr.io/conductorone/baton:latest. If the same registry deprecation applies to the CLI image, updating it here too would keep the docker snippet internally consistent; otherwise the mixed registries in back-to-back commands may read as an oversight. Non-blocking — I can't verify from this repo whether the CLI image is published to public.ecr.aws.

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Connector PR Review: Update deprecated ghcr.io image reference to public.ecr.aws

Blocking Issues: 0 | Suggestions: 1 | Threads Resolved: 0
Criteria: Criteria status: loaded .claude/skills/ci-review.md from trusted base ea0468d4c1b6.
Review mode: full
View review run

Review Summary

This PR changes a single documentation line, swapping the docker image reference for this connector in README.md from ghcr.io/conductorone/baton-aws:latest to public.ecr.aws/conductorone/baton-aws:latest. The full PR diff was scanned for security and correctness issues; no Go source, go.mod/go.sum, config, provisioning, or generated files are touched, so no connector behavior, dependency, or breaking-change criteria apply. There were no prior findings on this PR, and no new blocking issues were found.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

  • README.md:23 — the adjacent baton CLI image still uses ghcr.io/conductorone/baton:latest, leaving two registries in back-to-back commands; consider whether the same registry migration applies to it (low confidence — the PR deliberately scopes the change to the image for this connector).
Prompt for AI agents
Verify each finding against the current code and only fix it if needed.

## Suggestions

In `README.md`:
- Around line 23: The docker snippet now mixes two registries. Line 22 uses
  `public.ecr.aws/conductorone/baton-aws:latest` while line 23 still uses
  `ghcr.io/conductorone/baton:latest` for the baton CLI image. Confirm whether the
  baton CLI image is also published to `public.ecr.aws/conductorone/baton`. If it is,
  update line 23 to `public.ecr.aws/conductorone/baton:latest` so both commands use
  the same registry. If the CLI image is intentionally still hosted on ghcr.io, leave
  it unchanged - no fix needed.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant