Skip to content

Update deprecated ghcr.io image reference to public.ecr.aws - #189

Open
luisina-santos wants to merge 1 commit into
mainfrom
luisinasantos/fix-ghcr-image-references
Open

Update deprecated ghcr.io image reference to public.ecr.aws#189
luisina-santos wants to merge 1 commit into
mainfrom
luisinasantos/fix-ghcr-image-references

Conversation

@luisina-santos

Copy link
Copy Markdown
Contributor

Summary

  • README.md referenced this connector's image via ghcr.io/conductorone/baton-github:latest; container images are now published to public.ecr.aws/conductorone/baton-github:latest instead.
  • Only this connector's own image reference was updated.
  • Related audit: CXH-2418.

Test plan

  • Verified public.ecr.aws/conductorone/baton-github:latest resolves (manifest exists) before opening this PR.
  • Diff reviewed — only the image domain changed.

🤖 Generated with Claude Code

README.md referenced this connector's image via ghcr.io/conductorone;
container images are now published to public.ecr.aws/conductorone
instead. Only this connector's own image reference was updated.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Connector PR Review: Update deprecated ghcr.io image reference to public.ecr.aws

Blocking Issues: 0 | Suggestions: 1 | Threads Resolved: 0
Criteria: Criteria status: loaded .claude/skills/ci-review.md from trusted base 145e427ef1fa.
Review mode: full
View review run

Review Summary

The full PR diff was scanned for security and correctness issues; it is a single-line documentation change in README.md swapping this connector's Docker image registry from ghcr.io/conductorone/baton-github:latest to public.ecr.aws/conductorone/baton-github:latest. No Go source, go.mod, go.sum, config, or provisioning code changed, so no connector implementation, dependency, or breaking-change criteria apply. No blocking issues found; one optional follow-up on the adjacent unchanged line.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

  • README.md:24 — the adjacent baton CLI example still pulls from ghcr.io/conductorone/baton:latest. The PR description says this was deliberately left alone because it belongs to a different image, but if the same registry deprecation (CXH-2418) covers it, the README will read as inconsistent until it is updated too. Low confidence, non-blocking.
Prompt for AI agents
Verify each finding against the current code and only fix it if needed.

## Suggestions

In `README.md`:
- Around line 24: The second docker example still references `ghcr.io/conductorone/baton:latest` for the `baton` CLI image while line 23 was updated to `public.ecr.aws`. Confirm whether the `baton` CLI image is also published to `public.ecr.aws/conductorone/baton:latest`; if it is, update line 24 to use that registry so both examples are consistent. If the `baton` CLI image is intentionally still on ghcr.io, leave it unchanged.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant