Skip to content

Update deprecated ghcr.io image reference to public.ecr.aws - #29

Open
luisina-santos wants to merge 1 commit into
mainfrom
luisinasantos/fix-ghcr-image-references
Open

Update deprecated ghcr.io image reference to public.ecr.aws#29
luisina-santos wants to merge 1 commit into
mainfrom
luisinasantos/fix-ghcr-image-references

Conversation

@luisina-santos

Copy link
Copy Markdown

Summary

  • README.md referenced this connector's image via ghcr.io/conductorone/baton-jamf:latest; container images are now published to public.ecr.aws/conductorone/baton-jamf:latest instead.
  • Only this connector's own image reference was updated.
  • Related audit: CXH-2418.

Test plan

  • Verified public.ecr.aws/conductorone/baton-jamf:latest resolves (manifest exists) before opening this PR.
  • Diff reviewed — only the image domain changed.

🤖 Generated with Claude Code

README.md referenced this connector's image via ghcr.io/conductorone;
container images are now published to public.ecr.aws/conductorone
instead. Only this connector's own image reference was updated.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Comment thread README.md
```
docker run --rm -v $(pwd):/out -e BATON_USERNAME=jamfUsername BATON_PASSWORD=jamfPassword BATON_INSTANCE_URL=https://jamfProServerUrl.example.com ghcr.io/conductorone/baton-jamf:latest -f "/out/sync.c1z"
docker run --rm -v $(pwd):/out -e BATON_USERNAME=jamfUsername BATON_PASSWORD=jamfPassword BATON_INSTANCE_URL=https://jamfProServerUrl.example.com public.ecr.aws/conductorone/baton-jamf:latest -f "/out/sync.c1z"
docker run --rm -v $(pwd):/out ghcr.io/conductorone/baton:latest -f "/out/sync.c1z" resources

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Suggestion: The very next line still pulls the baton CLI from ghcr.io/conductorone/baton:latest. The PR description scopes this change to this connector's own image, so this may be intentional — but if the baton CLI image has also moved to public.ecr.aws, updating both here keeps the copy-paste docker block working end to end.

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Connector PR Review: Update deprecated ghcr.io image reference to public.ecr.aws

Blocking Issues: 0 | Suggestions: 1 | Threads Resolved: 0
Criteria: Criteria status: loaded .claude/skills/ci-review.md from trusted base 50cf865f1a8f.
Review mode: full
View review run

Review Summary

The full PR diff was scanned for security and correctness: it is a single-line README change swapping this connector's image reference from ghcr.io/conductorone/baton-jamf:latest to public.ecr.aws/conductorone/baton-jamf:latest. No Go source, go.mod, go.sum, config, or provisioning files changed, so no connector-behavior, dependency, or breaking-change criteria apply. The new registry path matches what docs/connector.mdx:228 already documents, so docs and README are now consistent; one leftover ghcr.io reference on the adjacent line is noted below.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

  • README.md:55 — the adjacent baton CLI pull still uses ghcr.io/conductorone/baton:latest; consider updating it too if that image has also migrated (explicitly out of scope per the PR description).
Prompt for AI agents
Verify each finding against the current code and only fix it if needed.

## Suggestions

In `README.md`:
- Around line 55: The docker usage block was updated on line 54 to pull this connector
  from `public.ecr.aws/conductorone/baton-jamf:latest`, but line 55 still pulls the
  `baton` CLI from `ghcr.io/conductorone/baton:latest`. Confirm whether the `baton` CLI
  image has also been republished to `public.ecr.aws/conductorone/baton:latest`; if it
  has, update line 55 to that registry so the two-command copy-paste block is
  internally consistent. If the CLI image has not migrated, leave line 55 unchanged.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant