Skip to content

Update deprecated ghcr.io image reference to public.ecr.aws - #28

Open
luisina-santos wants to merge 1 commit into
mainfrom
luisinasantos/fix-ghcr-image-references
Open

Update deprecated ghcr.io image reference to public.ecr.aws#28
luisina-santos wants to merge 1 commit into
mainfrom
luisinasantos/fix-ghcr-image-references

Conversation

@luisina-santos

Copy link
Copy Markdown
Contributor

Summary

  • README.md referenced this connector's image via ghcr.io/conductorone/baton-mysql:latest; container images are now published to public.ecr.aws/conductorone/baton-mysql:latest instead.
  • Only this connector's own image reference was updated.
  • Related audit: CXH-2418.

Test plan

  • Verified public.ecr.aws/conductorone/baton-mysql:latest resolves (manifest exists) before opening this PR.
  • Diff reviewed — only the image domain changed.

🤖 Generated with Claude Code

README.md referenced this connector's image via ghcr.io/conductorone;
container images are now published to public.ecr.aws/conductorone
instead. Only this connector's own image reference was updated.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Connector PR Review: Update deprecated ghcr.io image reference to public.ecr.aws

Blocking Issues: 0 | Suggestions: 1 | Threads Resolved: 0
Criteria: Criteria status: none loaded - could not read .claude/skills/ci-review.md at trusted base 218b5971ebcd: gh: Internal Server Error (HTTP 500).
Review mode: full
View review run

Review Summary

Scanned the full PR diff for security and correctness. The change is a single documentation line in README.md that repoints this connector's docker image from ghcr.io/conductorone/baton-mysql:latest to public.ecr.aws/conductorone/baton-mysql:latest, which matches the registry already used in docs/connector.mdx:192. No Go source, dependency manifests (go.mod/go.sum), config, or provisioning code changed, so no connector implementation, breaking-change, or dependency criteria apply.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

  • README.md:24 — the adjacent baton CLI image in the same copy-paste block still points at ghcr.io/conductorone/baton:latest; if the ghcr deprecation covers all ConductorOne images, this line will break too (low confidence — it belongs to a different repo's image and the PR explicitly scoped itself to this connector's image).
Prompt for AI agents
Verify each finding against the current code and only fix it if needed.

## Suggestions

In `README.md`:
- Around line 24: The docker example block now mixes registries — line 23 uses
  `public.ecr.aws/conductorone/baton-mysql:latest` while line 24 still uses
  `ghcr.io/conductorone/baton:latest` for the baton CLI image. Confirm whether the
  baton CLI image has also moved to `public.ecr.aws/conductorone/baton:latest`; if it
  has, update line 24 to match so the copy-paste block is consistent. If the CLI image
  is still published to ghcr.io, leave it as is.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant