Skip to content

Update deprecated ghcr.io image reference to public.ecr.aws - #40

Open
luisina-santos wants to merge 1 commit into
mainfrom
luisinasantos/fix-ghcr-image-references
Open

Update deprecated ghcr.io image reference to public.ecr.aws#40
luisina-santos wants to merge 1 commit into
mainfrom
luisinasantos/fix-ghcr-image-references

Conversation

@luisina-santos

Copy link
Copy Markdown

Summary

  • README.md referenced this connector's image via ghcr.io/conductorone/baton-retool:latest; container images are now published to public.ecr.aws/conductorone/baton-retool:latest instead.
  • Only this connector's own image reference was updated.
  • Related audit: CXH-2418.

Test plan

  • Verified public.ecr.aws/conductorone/baton-retool:latest resolves (manifest exists) before opening this PR.
  • Diff reviewed — only the image domain changed.

🤖 Generated with Claude Code

README.md referenced this connector's image via ghcr.io/conductorone;
container images are now published to public.ecr.aws/conductorone
instead. Only this connector's own image reference was updated.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Comment thread README.md
```
docker run --rm -v $(pwd):/out -e BATON_CONNECTION_STRING="user=baton password=baton host=localhost port=5432 dbname=hammerhead_production" ghcr.io/conductorone/baton-retool:latest -f "/out/sync.c1z"
docker run --rm -v $(pwd):/out -e BATON_CONNECTION_STRING="user=baton password=baton host=localhost port=5432 dbname=hammerhead_production" public.ecr.aws/conductorone/baton-retool:latest -f "/out/sync.c1z"
docker run --rm -v $(pwd):/out ghcr.io/conductorone/baton:latest -f "/out/sync.c1z" resources

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Suggestion: The next line in the same code block still points at ghcr.io/conductorone/baton:latest. That's the baton CLI image rather than this connector's image, so it's outside the stated scope of this PR — but if ghcr.io is deprecated for all ConductorOne images, this reference will break for anyone copy-pasting the docker section. Worth confirming whether public.ecr.aws/conductorone/baton:latest exists and updating it here too.

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

Connector PR Review: Update deprecated ghcr.io image reference to public.ecr.aws

Blocking Issues: 0 | Suggestions: 1 | Threads Resolved: 0
Criteria: Criteria status: loaded .claude/skills/ci-review.md from trusted base 778d20979768.
Review mode: full
View review run

Review Summary

The full PR diff was scanned for security and correctness: it is a single-line documentation change in README.md that swaps the docker image registry for this connector from ghcr.io/conductorone/baton-retool:latest to public.ecr.aws/conductorone/baton-retool:latest. No Go source, go.mod, go.sum, config, or provisioning code changed, so no connector behavior, dependency, or breaking-change criteria apply. The new reference is consistent with docs/connector.mdx:207, which already uses public.ecr.aws/conductorone/baton-retool:latest.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

  • README.md:83 — the adjacent baton CLI docker command in the same code block still references ghcr.io/conductorone/baton:latest (outside the stated scope of this PR, but likely stale for the same reason).

Note: the machine-readable review-state marker could not be written by this run because the sandbox command guard rejects it; the next review will run in full mode. Reviewed head SHA 2dc332a against base 778d209.

Prompt for AI agents
Verify each finding against the current code and only fix it if needed.

## Suggestions

In `README.md`:
- Around line 83: The docker code block still runs the baton CLI image from the deprecated registry host `ghcr.io/conductorone/baton:latest`. This is a different image from the connector image updated on line 82, so confirm first that `public.ecr.aws/conductorone/baton:latest` is published; if it is, change the registry host on line 83 to `public.ecr.aws` so the whole docker section is consistent. If the baton CLI image is intentionally still published only to ghcr.io, leave line 83 unchanged.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant