Update deprecated ghcr.io image reference to public.ecr.aws - #47
Update deprecated ghcr.io image reference to public.ecr.aws#47luisina-santos wants to merge 1 commit into
Conversation
README.md referenced this connector's image via ghcr.io/conductorone; container images are now published to public.ecr.aws/conductorone instead. Only this connector's own image reference was updated. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
|
||
| ``` | ||
| docker run --rm -v $(pwd):/out -e BATON_TOKEN=oauth2Token BATON_SERVICE_PROVIDER=slack baton-scim ghcr.io/conductorone/baton-scim:latest -f "/out/sync.c1z" | ||
| docker run --rm -v $(pwd):/out -e BATON_TOKEN=oauth2Token BATON_SERVICE_PROVIDER=slack baton-scim public.ecr.aws/conductorone/baton-scim:latest -f "/out/sync.c1z" |
There was a problem hiding this comment.
🟡 Suggestion: This docker run invocation is malformed (pre-existing, but on the line you touched). Docker will parse BATON_SERVICE_PROVIDER=slack as the image name, since the second env var is missing its own -e flag and the stray baton-scim sits before the image reference. Since you're already correcting this line, consider making it copy-pasteable:
| docker run --rm -v $(pwd):/out -e BATON_TOKEN=oauth2Token BATON_SERVICE_PROVIDER=slack baton-scim public.ecr.aws/conductorone/baton-scim:latest -f "/out/sync.c1z" | |
| docker run --rm -v $(pwd):/out -e BATON_TOKEN=oauth2Token -e BATON_SERVICE_PROVIDER=slack public.ecr.aws/conductorone/baton-scim:latest -f "/out/sync.c1z" |
| ``` | ||
| docker run --rm -v $(pwd):/out -e BATON_TOKEN=oauth2Token BATON_SERVICE_PROVIDER=slack baton-scim ghcr.io/conductorone/baton-scim:latest -f "/out/sync.c1z" | ||
| docker run --rm -v $(pwd):/out -e BATON_TOKEN=oauth2Token BATON_SERVICE_PROVIDER=slack baton-scim public.ecr.aws/conductorone/baton-scim:latest -f "/out/sync.c1z" | ||
| docker run --rm -v $(pwd):/out ghcr.io/conductorone/baton:latest -f "/out/sync.c1z" resources |
There was a problem hiding this comment.
🟡 Suggestion: The baton CLI image on the next line still points at ghcr.io/conductorone/baton:latest. The PR description says only this connector's own image was intentionally in scope, so this may be deliberate — but if CXH-2418 covers all ConductorOne images, users copy-pasting this block will still hit the deprecated registry for the second command.
Connector PR Review: Update deprecated ghcr.io image reference to public.ecr.awsBlocking Issues: 0 | Suggestions: 2 | Threads Resolved: 0 Review SummaryThis PR changes a single README line, swapping the connector's Docker image reference from Security IssuesNone found. Correctness IssuesNone found. Suggestions
Prompt for AI agents |
Summary
ghcr.io/conductorone/baton-scim:latest; container images are now published topublic.ecr.aws/conductorone/baton-scim:latestinstead.Test plan
public.ecr.aws/conductorone/baton-scim:latestresolves (manifest exists) before opening this PR.🤖 Generated with Claude Code