Skip to content

Update deprecated ghcr.io image reference to public.ecr.aws - #99

Open
luisina-santos wants to merge 1 commit into
mainfrom
luisinasantos/fix-ghcr-image-references
Open

Update deprecated ghcr.io image reference to public.ecr.aws#99
luisina-santos wants to merge 1 commit into
mainfrom
luisinasantos/fix-ghcr-image-references

Conversation

@luisina-santos

Copy link
Copy Markdown
Contributor

Summary

  • README.md referenced this connector's image via ghcr.io/conductorone/baton-slack:latest; container images are now published to public.ecr.aws/conductorone/baton-slack:latest instead.
  • Only this connector's own image reference was updated.
  • Related audit: CXH-2418.

Test plan

  • Verified public.ecr.aws/conductorone/baton-slack:latest resolves (manifest exists) before opening this PR.
  • Diff reviewed — only the image domain changed.

🤖 Generated with Claude Code

README.md referenced this connector's image via ghcr.io/conductorone;
container images are now published to public.ecr.aws/conductorone
instead. Only this connector's own image reference was updated.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Comment thread README.md
```
docker run --rm -v $(pwd):/out -e BATON_TOKEN=token ghcr.io/conductorone/baton-slack:latest -f "/out/sync.c1z"
docker run --rm -v $(pwd):/out -e BATON_TOKEN=token public.ecr.aws/conductorone/baton-slack:latest -f "/out/sync.c1z"
docker run --rm -v $(pwd):/out ghcr.io/conductorone/baton:latest -f "/out/sync.c1z" resources

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Suggestion: The next line still pulls the baton CLI image from the deprecated ghcr.io registry. It's a different image than this connector's (so intentionally out of scope per the PR description), but if the whole conductorone org has migrated to public.ecr.aws, this line will break for readers following the docker section end-to-end. Worth confirming whether public.ecr.aws/conductorone/baton:latest exists and updating it in the same pass.

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Connector PR Review: Update deprecated ghcr.io image reference to public.ecr.aws

Blocking Issues: 0 | Suggestions: 1 | Threads Resolved: 0
Criteria: Criteria status: loaded .claude/skills/ci-review.md from trusted base 5cca47207a02.
Review mode: full
View review run

Review Summary

This PR changes a single README line, swapping the connector's docker image reference from ghcr.io/conductorone/baton-slack:latest to public.ecr.aws/conductorone/baton-slack:latest. The full PR diff was scanned for security and correctness issues; there is no Go code, dependency manifest (go.mod/go.sum), or config change, so no connector implementation, provisioning, or breaking-change criteria apply. The new reference is consistent with docs/connector.mdx:279, which already points at public.ecr.aws/conductorone/baton-slack:latest, so no documentation staleness was introduced.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

  • README.md:58 — the adjacent baton CLI pull still uses the deprecated ghcr.io/conductorone/baton:latest registry (low confidence; a different image and explicitly out of scope per the PR description).
Prompt for AI agents
Verify each finding against the current code and only fix it if needed.

## Suggestions

In `README.md`:
- Around line 58: The docker section's second command still pulls the `baton` CLI from the
  deprecated registry: `ghcr.io/conductorone/baton:latest`. Line 57 was migrated to
  `public.ecr.aws` in this PR but line 58 was not, so a reader following the docker section
  end-to-end hits one migrated and one deprecated registry. Confirm whether
  `public.ecr.aws/conductorone/baton:latest` is published; if it is, update line 58 to
  `docker run --rm -v $(pwd):/out public.ecr.aws/conductorone/baton:latest -f "/out/sync.c1z" resources`.
  If the `baton` CLI image is intentionally still hosted on ghcr.io, leave it as-is.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant