Skip to content

Update deprecated ghcr.io image reference to public.ecr.aws - #53

Open
luisina-santos wants to merge 1 commit into
mainfrom
luisinasantos/fix-ghcr-image-references
Open

Update deprecated ghcr.io image reference to public.ecr.aws#53
luisina-santos wants to merge 1 commit into
mainfrom
luisinasantos/fix-ghcr-image-references

Conversation

@luisina-santos

Copy link
Copy Markdown
Contributor

Summary

  • README.md referenced this connector's image via ghcr.io/conductorone/baton-tableau:latest; container images are now published to public.ecr.aws/conductorone/baton-tableau:latest instead.
  • Only this connector's own image reference was updated.
  • Related audit: CXH-2418.

Test plan

  • Verified public.ecr.aws/conductorone/baton-tableau:latest resolves (manifest exists) before opening this PR.
  • Diff reviewed — only the image domain changed.

🤖 Generated with Claude Code

README.md referenced this connector's image via ghcr.io/conductorone;
container images are now published to public.ecr.aws/conductorone
instead. Only this connector's own image reference was updated.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Comment thread README.md
```
docker run --rm -v $(pwd):/out -e BATON_ACCESS_TOKEN_NAME=your-token-name -e BATON_ACCESS_TOKEN_SECRET=your-token-secret -e BATON_SERVER_PATH=us-east-1.online.tableau.com -e BATON_SITE_ID=your-site-id ghcr.io/conductorone/baton-tableau:latest -f "/out/sync.c1z"
docker run --rm -v $(pwd):/out -e BATON_ACCESS_TOKEN_NAME=your-token-name -e BATON_ACCESS_TOKEN_SECRET=your-token-secret -e BATON_SERVER_PATH=us-east-1.online.tableau.com -e BATON_SITE_ID=your-site-id public.ecr.aws/conductorone/baton-tableau:latest -f "/out/sync.c1z"
docker run --rm -v $(pwd):/out ghcr.io/conductorone/baton:latest -f "/out/sync.c1z" resources

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Suggestion: The next line in the same code block still points at ghcr.io/conductorone/baton:latest. If the ghcr.io deprecation is org-wide (as the PR description implies), this reference is stale too and users copying the block will hit the deprecated registry for the second command. Worth confirming whether public.ecr.aws/conductorone/baton:latest is published and updating it here as well. (Confidence: medium — the baton CLI image lives in a different repo, so the scoping choice may be deliberate.)

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Connector PR Review: Update deprecated ghcr.io image reference to public.ecr.aws

Blocking Issues: 0 | Suggestions: 1 | Threads Resolved: 0
Criteria: Criteria status: loaded .claude/skills/ci-review.md from trusted base ab289934655c.
Review mode: full
View review run

Review Summary

This PR is a single-line documentation change swapping the connector's own docker image reference in README.md from ghcr.io/conductorone/baton-tableau:latest to public.ecr.aws/conductorone/baton-tableau:latest. The full PR diff was scanned for security and correctness issues; there are no Go, config, dependency (go.mod/go.sum), or provisioning changes, so no connector implementation criteria apply. docs/connector.mdx:253 already uses public.ecr.aws, so this change brings the README into alignment with existing docs.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

  • README.md:27 — the adjacent baton CLI command in the same code block still references ghcr.io/conductorone/baton:latest; worth confirming whether it should also move to public.ecr.aws.
Prompt for AI agents
Verify each finding against the current code and only fix it if needed.

## Suggestions

In `README.md`:
- Around line 27: The docker code block was updated so the connector image uses
  `public.ecr.aws/conductorone/baton-tableau:latest`, but the second command on the
  next line still uses the deprecated `ghcr.io/conductorone/baton:latest` for the
  baton CLI image. Check whether `public.ecr.aws/conductorone/baton:latest` is
  published; if it is, update this line to use it so the whole code block points at
  the current registry. If the baton CLI image is intentionally still on ghcr.io,
  leave it as-is.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant