feat(storage): Admin UI for GCS JSON credentials and File.uri - #320
Open
ChrisPdgn wants to merge 3 commits into
Open
feat(storage): Admin UI for GCS JSON credentials and File.uri#320ChrisPdgn wants to merge 3 commits into
ChrisPdgn wants to merge 3 commits into
Conversation
Add Google serviceAccountKeyJson alongside key path (ADC when both empty) and display File.uri in the file details sheet. Co-authored-by: Christina Papadogianni <ChrisPdgn@users.noreply.github.com>
Keep ADC optional fields while preserving StorageSettings string types for settings submit.
ChrisPdgn
force-pushed
the
cursor/storage-gcs-json-and-file-uri-6a2d
branch
from
September 10, 2026 13:18
d26c3bd to
a4fc7d9
Compare
Load FileDetailsSheet with Promise.allSettled so a URL fetch error still shows metadata and Conduit URI; download/open stay URL-gated.
ChrisPdgn
marked this pull request as ready for review
September 10, 2026 13:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
masterbranchui-rewrite(current Admin rewrite base)fix #xxx, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Why
Admin UI counterpart to backend Conduit #1509 (
feat(storage): add GCS parity and public file URI semantics).Mapping to Conduit #1509
google.serviceAccountKeyJson— inline service account JSONFile.uri— stable Conduit-relative path (/storage/getFileUrl/:id)File.url/sourceUrl— direct provider/CDN URLs only when container and file are publicConduitFile. Actionable download/open/preview still usesgetFileUrl(fileId), notfile.url.Leave both Google credential fields empty to use Application Default Credentials. Do not set JSON if a key path is provided.
Zod note: fields use
.optional().or(z.literal('')).default('')so an omitted backendserviceAccountKeyJsonbecomes''and stays assignable toStorageSettingson save (no change tosettings.tsx).Test plan
serviceAccountKeyJson(empty-string fallback).file.uriis present, Conduit URI renders above the existing URL block; copy button toastsURI copied to clipboard.getFileUrland are unchanged whenuriis absent.Local verification
pnpm exec tsc --noEmitpassespnpm exec eslinton the five files: no errors (pre-existing@next/next/no-img-elementwarning in FileDetailsSheet)min(5)unchangedLive Storage settings / File details against a Conduit instance running #1509 was not available in this environment.
Scope
Only these files:
src/lib/models/storage/settings.tssrc/components/storage/settings/zod.tssrc/components/storage/settings/settingsForm.tsxsrc/lib/models/storage/schemas.tssrc/components/storage/browse/FileDetailsSheet.tsxDraft until backend #1509 lands and this is manually verified against a live storage module.