fix(database): detect wrapped Relation field types - #322
Merged
Conversation
Array relations stored as { type: [{ type: Relation, model }] }
were shown as String, so saving could drop the relation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
masterbranchfix #xxx, where "xxx" is the issue number)Other information:
In Database → Models → schema fields, array relations often showed as String instead of Relation, with no related-model picker. Saving that view would persist
{ type: "String" }and drop the relation.Scalar relations (
{ type: "Relation", model: "User" }) already worked. The miss was Conduit’s wrapped array form, common in production schemas:{ "type": [{ "type": "Relation", "model": "Team" }] }The editor now unwraps that shape (and
{ type: ["Relation"], model }) and treats a stringmodelas Relation. The document form uses the same parser, so those fields get the relation picker instead of a text input. Saving still writes the canonical[ { type: "Relation", model } ]array.Test plan
pnpm test:schema-fields— 9 cases covering scalar Relation, both array encodings, String arrays, Group, and missing type{ type: [{ type: "Relation", model }] }(e.g.sharedWithTeams) and confirm type is Relation, model picker is filled, array is on{ type: ["String"] }stays String with array onCould not exercise the UI locally in this pass (no running admin server).