refactor(functions): deslop cron scheduler from #1507 - #1599
Merged
cursor[bot] merged 3 commits intoSep 10, 2026
Merged
cursor[bot] merged 3 commits into
cursor[bot] merged 3 commits into
Conversation
Flatten refreshRoutes, drop redundant cron prep/active checks, and move unit tests into src/__tests__. Revert unrelated 2FA and pnpm allowBuilds drive-bys from the cron PR. Co-authored-by: Christina Papadogianni <ChrisPdgn@users.noreply.github.com>
TypeScript 6 infers Array<number | undefined>.reduce as possibly undefined; use an explicit loop so tsc --noEmit stays clean. Co-authored-by: Christina Papadogianni <ChrisPdgn@users.noreply.github.com>
Co-authored-by: Christina Papadogianni <ChrisPdgn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #1507’s cron scheduler works, but the new code was noisy: nested try/catch in
refreshRoutes, a duplicateconfig.activecheck, tests sitting next to controllers, and unrelated 2FA /pnpm-workspacedrive-bys.Summary
Cleanup only — scheduling, drain, and lock behavior are unchanged.
refreshRoutesto one try per function; cron prep failures still skip that functionconfig.activecheck and the discardedCronQueueController.getInstance()callqueue.addsucceedsmodules/functions/src/__tests__/generateSecret/allowBuildschanges from the cron PRWhat kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
mainbranchThis is a cleanup PR into
feat/functions-cron-scheduler(#1507).Test plan
pnpm --filter @conduitplatform/functions test— 19/19 passedpnpm --filter @conduitplatform/functions exec tsc --noEmit