Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .Jules/palette.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,7 @@
## 2024-11-20 - CopyPromptButton ์ ‘๊ทผ์„ฑ ํ–ฅ์ƒ (๋™์  ํ…์ŠคํŠธ ๋ฐ ์ƒํƒœ)
**Learning:** `CopyPromptButton`๊ณผ ๊ฐ™์ด ๋ฒ„ํŠผ์„ ํด๋ฆญํ–ˆ์„ ๋•Œ ์‹œ๊ฐ์ ์œผ๋กœ๋งŒ ์ƒํƒœ๊ฐ€ ๋ณ€ํ•˜๊ณ (์˜ˆ: ๋ณต์‚ฌ ์•„์ด์ฝ˜์ด ์ฒดํฌ ์•„์ด์ฝ˜์œผ๋กœ ๋ณ€๊ฒฝ), ํ…์ŠคํŠธ๊ฐ€ ๋™์ ์œผ๋กœ ๋ณ€๊ฒฝ๋˜๋Š” ์ปดํฌ๋„ŒํŠธ์—์„œ๋Š” ์Šคํฌ๋ฆฐ ๋ฆฌ๋” ์‚ฌ์šฉ์ž๊ฐ€ ์ƒํƒœ ๋ณ€ํ™”๋ฅผ ์•Œ์•„์ฑ„๊ธฐ ์–ด๋ ต์Šต๋‹ˆ๋‹ค. ๋˜ํ•œ ์Šคํฌ๋ฆฐ ๋ฆฌ๋”๊ฐ€ ์ˆœ์ˆ˜ ์žฅ์‹์šฉ ์•„์ด์ฝ˜๊นŒ์ง€ ๋ถˆํ•„์š”ํ•˜๊ฒŒ ์ฝ์„ ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.
**Action:** ๋™์ ์œผ๋กœ ๋ณ€๊ฒฝ๋˜๋Š” ํ…์ŠคํŠธ๋ฅผ `<span aria-live="polite">`๋กœ ๊ฐ์‹ธ ์Šคํฌ๋ฆฐ ๋ฆฌ๋”๊ฐ€ ์ฆ‰์‹œ ๋ณ€๊ฒฝ ์‚ฌํ•ญ์„ ์ฝ์–ด์ฃผ๋„๋ก ํ•ด์•ผ ํ•ฉ๋‹ˆ๋‹ค. `<Button>` ์ปดํฌ๋„ŒํŠธ์—๋Š” `aria-pressed={copied}`๋ฅผ ์ถ”๊ฐ€ํ•˜์—ฌ ํ† ๊ธ€ ์„ฑ๊ฒฉ์„ ๋ถ€์—ฌํ•˜๊ณ , ์‹œ๊ฐ์ ์ธ ์•„์ด์ฝ˜ ์ปดํฌ๋„ŒํŠธ(์˜ˆ: `<Copy>`, `<Check>`)์—๋Š” `aria-hidden="true"`๋ฅผ ์ถ”๊ฐ€ํ•˜์—ฌ ์Šคํฌ๋ฆฐ ๋ฆฌ๋”์—์„œ ๋ฌด์‹œํ•˜๋„๋ก ์ฒ˜๋ฆฌํ•˜๋Š” ํŒจํ„ด์„ ์ง€์†์ ์œผ๋กœ ์‚ฌ์šฉํ•ด์•ผ ํ•ฉ๋‹ˆ๋‹ค.

## 2025-02-15 - Replace Raw Button Elements with Design System Components for Accessibility
**Learning:** ์• ํ”Œ๋ฆฌ์ผ€์ด์…˜ ๊ณณ๊ณณ(์˜ˆ: `org-sidebar.tsx`, `no-organization-state.tsx`์˜ ๋กœ๊ทธ์•„์›ƒ ๋ฒ„ํŠผ)์—์„œ ๊ณต์œ  ๋””์ž์ธ ์‹œ์Šคํ…œ ์ปดํฌ๋„ŒํŠธ(`<Button>`) ๋Œ€์‹  ๊ธฐ๋ณธ HTML `<button>` ์š”์†Œ๋ฅผ ์‚ฌ์šฉํ•  ๊ฒฝ์šฐ, `focus-visible`๊ณผ ๊ฐ™์€ ํ‚ค๋ณด๋“œ ์ ‘๊ทผ์„ฑ ์Šคํƒ€์ผ์ด ๋ˆ„๋ฝ๋˜๊ฑฐ๋‚˜ ๋””์ž์ธ ์ƒํƒœ๊ฐ€ ์ผ๊ด€๋˜์ง€ ์•Š๊ฒŒ ์ ์šฉ๋˜๋Š” ๋ฌธ์ œ๊ฐ€ ๋ฐœ์ƒํ•ฉ๋‹ˆ๋‹ค.
**Action:** ํ•ญ์ƒ ๊ณต์œ  ๋””์ž์ธ ์‹œ์Šคํ…œ ์ปดํฌ๋„ŒํŠธ(์˜ˆ: `@/components/ui/button`์˜ `Button`)๋ฅผ ์‚ฌ์šฉํ•˜์—ฌ ํ‚ค๋ณด๋“œ ๋‚ด๋น„๊ฒŒ์ด์…˜ ์‚ฌ์šฉ์ž๋ฅผ ์œ„ํ•œ ์ผ๊ด€๋œ ํฌ์ปค์Šค ๋ง๊ณผ ์ ‘๊ทผ์„ฑ์„ ๋ณด์žฅํ•ด์•ผ ํ•ฉ๋‹ˆ๋‹ค.
6 changes: 6 additions & 0 deletions commit_message.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
๐ŸŽจ Palette: OSV ๋ณด์•ˆ ์ทจ์•ฝ์ (deepmerge-ts) ์ˆ˜์ • ๋ฐ pnpm-lock.yaml ๊ฐฑ์‹ 

๐Ÿ’ก What: `package.json`์˜ overrides ํ•ญ๋ชฉ์— `deepmerge-ts: ^8.0.0`์„ ์ถ”๊ฐ€ํ•˜์—ฌ `deepmerge-ts`๋ฅผ ๋ฒ„์ „ 8.0.1๋กœ ์—…๊ทธ๋ ˆ์ด๋“œํ–ˆ์Šต๋‹ˆ๋‹ค.
๐ŸŽฏ Why: GitHub CI OSV-Scanner์—์„œ `deepmerge-ts` ๋ฒ„์ „ 7.1.5์˜ ์ทจ์•ฝ์ (GHSA-ggr8-5vv4-36mx)์ด ๋ฐœ๊ฒฌ๋˜์–ด ๋นŒ๋“œ ์‹คํŒจ๊ฐ€ ๋ฐœ์ƒํ–ˆ๊ธฐ ๋•Œ๋ฌธ์ž…๋‹ˆ๋‹ค.
๐Ÿ“ธ Before/After: ๋นŒ๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ํ†ต๊ณผ๋˜๋ฉฐ, trivy-fs ์Šค์บ” ๋ฐ osv-scanner ์Šค์บ”์—์„œ ํ•ด๋‹น ์ทจ์•ฝ์ ์ด ๋” ์ด์ƒ ๊ฒ€์ถœ๋˜์ง€ ์•Š์Šต๋‹ˆ๋‹ค.
โ™ฟ Accessibility: N/A
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@
"undici": "^7.29.0",
"minimatch": "^10.0.0",
"@hono/node-server": "^2.0.5",
"body-parser": "^2.3.0"
"body-parser": "^2.3.0",
"deepmerge-ts": "^8.0.0"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,15 @@ export function NoOrganizationState({
<h1 className="text-xl font-semibold">Argos</h1>
<div className="flex items-center gap-3">
<span className="text-sm text-muted-foreground">{email}</span>
<button
<Button
variant="link"
size="sm"
onClick={() => signOut({ callbackUrl: '/login' })}
className="text-sm text-destructive hover:underline"
className="text-destructive hover:text-destructive p-0 h-auto font-normal"
aria-label="Log out of your account"
>
Log out
</button>
</Button>
</div>
</div>

Expand Down
16 changes: 10 additions & 6 deletions packages/web/src/components/layout/org-sidebar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { useParams, usePathname } from 'next/navigation'
import { useState } from 'react'
import { signOut } from 'next-auth/react'
import { cn } from '@/lib/utils'
import { Button } from '@/components/ui/button'
import { OrgSwitcher } from './org-switcher'
import { CreateOrgModal } from '@/components/org/create-org-modal'
import { useOrgs } from '@/hooks/use-orgs'
Expand Down Expand Up @@ -121,14 +122,15 @@ export function OrgSidebar() {
</div>
</nav>
<div className="p-3 border-t">
<button
<Button
type="button"
variant="ghost"
onClick={handleLogout}
className="w-full px-3 py-2 text-sm font-medium text-destructive hover:bg-destructive/10 rounded-md transition-colors focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-destructive/50"
className="w-full justify-start text-destructive hover:bg-destructive/10 hover:text-destructive"
aria-label="Log out of your account"
>
Log Out
</button>
</Button>
</div>
</aside>

Expand All @@ -149,14 +151,16 @@ export function OrgSidebar() {
<div className="flex-1 min-w-0">
<OrgSwitcher onCreateClick={() => setCreateOpen(true)} />
</div>
<button
<Button
type="button"
variant="ghost"
size="sm"
onClick={handleLogout}
className="px-3 py-1 text-sm text-destructive hover:bg-destructive/10 rounded-md transition-colors focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-destructive/50"
className="text-destructive hover:bg-destructive/10 hover:text-destructive"
aria-label="Log out of your account"
>
Logout
</button>
</Button>
</div>
<nav className="flex overflow-x-auto px-2 pb-2 gap-1">
{mobileNavItems.map((item) => renderLink(item, 'mobile'))}
Expand Down
9 changes: 5 additions & 4 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions pr_body.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
๐Ÿ’ก What: `no-organization-state.tsx` ๋ฐ `org-sidebar.tsx` ๋‚ด ๋กœ๊ทธ์•„์›ƒ(Log out) ๋™์ž‘์— ์‚ฌ์šฉ๋œ ๊ธฐ๋ณธ `<button>` HTML ํƒœ๊ทธ๋ฅผ `@/components/ui/button`์˜ `<Button>` ์ปดํฌ๋„ŒํŠธ๋กœ ๊ต์ฒดํ–ˆ์Šต๋‹ˆ๋‹ค.
๐ŸŽฏ Why: ๊ธฐ์กด์—๋Š” ๊ธฐ๋ณธ HTML `<button>`์ด ์‚ฌ์šฉ๋˜์–ด ํ‚ค๋ณด๋“œ ๋‚ด๋น„๊ฒŒ์ด์…˜ ์‚ฌ์šฉ์ž(Tab ์ด๋™)์—๊ฒŒ ์ดˆ์ ์ด ๋งž์„ ๋•Œ `focus-visible` ์ƒํƒœ๊ฐ€ ๋ช…ํ™•ํ•˜๊ฒŒ ๋ณด์ด์ง€ ์•Š๊ฑฐ๋‚˜ ์•ฑ ๋‚ด ๋‹ค๋ฅธ UI ์ปดํฌ๋„ŒํŠธ์™€ ์ผ๊ด€๋˜์ง€ ์•Š๋Š” ์ ‘๊ทผ์„ฑ ๋ฌธ์ œ๊ฐ€ ์žˆ์—ˆ์Šต๋‹ˆ๋‹ค. ์ด๋ฅผ ๊ณต์šฉ ์ปดํฌ๋„ŒํŠธ๋กœ ๋ณ€๊ฒฝํ•จ์œผ๋กœ์จ ์ผ๊ด€๋œ ๋””์ž์ธ๊ณผ ํ‚ค๋ณด๋“œ ์ ‘๊ทผ์„ฑ์„ ํ™•๋ณดํ–ˆ์Šต๋‹ˆ๋‹ค.
๐Ÿ“ธ Before/After: Playwright๋ฅผ ์‚ฌ์šฉํ•ด ์‹œ๊ฐ์  ๊ฒ€์ฆ์„ ์™„๋ฃŒํ–ˆ์œผ๋ฉฐ, ๋กœ๊ทธ์•„์›ƒ ๋ฒ„ํŠผ์ด ํƒญ์œผ๋กœ ํฌ์ปค์Šค๋˜์—ˆ์„ ๋•Œ ๋””์ž์ธ ์‹œ์Šคํ…œ ๊ธฐ์ค€์— ๋งž๊ฒŒ ๋‚˜ํƒ€๋‚ฉ๋‹ˆ๋‹ค.
โ™ฟ Accessibility: ๋ฒ„ํŠผ ํฌ์ปค์Šค ์ƒํƒœ(focus-visible)๋ฅผ ๋ช…ํ™•ํžˆ ํ•˜์—ฌ ์Šคํฌ๋ฆฐ ๋ฆฌ๋” ๋ฐ ํ‚ค๋ณด๋“œ ๋„ค๋น„๊ฒŒ์ด์…˜ ์‚ฌ์šฉ์„ฑ์„ ๊ฐœ์„ ํ–ˆ์Šต๋‹ˆ๋‹ค.
Loading