Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π¨ Palette: κΈ°κ° μ ν λ²νΌμ μ κ·Όμ± μμ± (aria-label) μΆκ° #492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: developmental
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
π¨ Palette: κΈ°κ° μ ν λ²νΌμ μ κ·Όμ± μμ± (aria-label) μΆκ° #492
Changes from all commits
d64310af0c2996File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π¨ GitHub Action unpinned from commit SHA to mutable tag
The checkout step is changed from a full commit SHA to the mutable
@v4tag. A mutable tag can be repointed to malicious code that then runs with CI privileges. The sibling osv-scanner step in the same file stays SHA-pinned, making this an inconsistent supply-chain downgrade.Was this helpful? React with π or π to provide feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π Info: Awkward aria-label wording for ALL preset
The ALL preset produces the aria-label
Select last all days, which reads awkwardly for screen reader users. A phrase likeSelect all timewould be clearer. Not a functional bug; the test was updated to match this wording.Was this helpful? React with π or π to provide feedback.
Uh oh!
There was an error while loading. Please reload this page.