-
Notifications
You must be signed in to change notification settings - Fork 0
๐จ Palette: [UX improvement] CopyPromptButton ์ ๊ทผ์ฑ ๊ฐ์ #494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: developmental
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -41,7 +41,10 @@ export function CopyPromptButton({ | |
| className={cn("gap-1.5", className)} | ||
| > | ||
| {copied ? <Check aria-hidden="true" /> : <Copy aria-hidden="true" />} | ||
| <span aria-live="polite"> | ||
| <span aria-hidden="true"> | ||
| {copied ? copiedLabel : label} | ||
| </span> | ||
| <span className="sr-only" role="status" aria-atomic="true"> | ||
| {copied ? copiedLabel : label} | ||
| </span> | ||
|
Comment on lines
+47
to
49
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ๐ Info: sr-only status span still contributes to accessible name The Was this helpful? React with ๐ or ๐ to provide feedback. |
||
| </Button> | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๐ Unrelated dependency override in package.json
The
deepmerge-tsoverride added to package.json is unrelated to the accessibility change this PR describes. Worth confirming it belongs here rather than being an incidental addition.Was this helpful? React with ๐ or ๐ to provide feedback.