fix(worker): refuse a SERVER_INTERNAL_URL that is not a valid http(s) URL - #389
Merged
davidmckayv merged 1 commit intoSep 6, 2026
Merged
Conversation
Ayush7614
requested review from
MikeRyanDev,
davidmckayv,
guidovizoso and
tylerslaton
as code owners
September 5, 2026 19:47
davidmckayv
approved these changes
Sep 6, 2026
davidmckayv
left a comment
davidmckayv
left a comment
Contributor
There was a problem hiding this comment.
Refuses a non-http(s) SERVER_INTERNAL_URL at worker boot (fail-closed), after the trailing-slash normalization. Read against live code + deep review: valid URLs pass, no new deps. CI approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
loadWorkerEnv only refused an empty or all-slash SERVER_INTERNAL_URL, so values like not-a-url or ftp://files/x passed boot and then failed every 30s sweep tick with a fetch TypeError logged as routine-sweep-tick-failed instead of a boot error.
Validates the normalised URL with new URL() and requires http(s), throwing a fail-fast boot error otherwise. Verified: all 17 existing worker env tests pass; not-a-url, ://bad, ftp: and padded junk are refused, http/https/trailing-slash URLs accepted.