fix(server): report a sandbox template that is not valid JSON as a SandboxError - #391
Merged
davidmckayv merged 3 commits intoSep 6, 2026
Merged
Conversation
Ayush7614
requested review from
MikeRyanDev,
davidmckayv,
guidovizoso and
tylerslaton
as code owners
September 5, 2026 19:48
davidmckayv
approved these changes
Sep 6, 2026
davidmckayv
left a comment
davidmckayv
left a comment
Contributor
There was a problem hiding this comment.
Deep-reviewed against live code (correctness, governance, no vendor/secret/scale issues). Composed build+tests green. CHANGELOG/format rebase on CI-validated substance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
readSandboxTemplate guarded the file read but not the parse: malformed JSON threw a bare SyntaxError and null/array JSON threw a TypeError on .podTemplate, bypassing the SandboxError handling the boot path expects for deployment misconfiguration.
Wraps JSON.parse and adds an object/null/array shape check so every bad template surfaces as SandboxError. Verified with a file-based script (malformed, null, array, missing podTemplate, valid) and all 8 existing computer-sandbox tests plus server typecheck green.