Conversation
The check by ifstream do fail on files with write only permission.
Used since Amlogic kernel 4.9.180 Use simple mixer control to set codec format for SPDIF-A and SPDIF-B. Also set SPDIF to HDMITX by simple mixer control to enable correct SPDIF output.
Since kernel 4.9.180 di_multi is used on new platforms. VC1 progressive does need to be deinterlaced as otherwise it get played too slow.
vadj1 need to be enabled to be able to use brightness1 and contrast1 controls. brightness1 control range got extended to -255..255
Fixed refresh rate switching for non-standard 4K and more higher 5K, 8K resolutions. Fixed correct switching while playing video file in bigger resolution and opening video file with lower resolution. Fixed using double refresh rate with whitelist.
On Kodi start GetCPUInfo is not initialized.
Regex expression needs to be adjusted because of the use of SysfsPath
…ting Update methods to match current kernel.
Update path check method for C++17
Kodi Nexus do not stop the video thread when a media file get opened while another one is already playing. So we must close the currently open decoder before opening a new one as the kernel is able to handle multiple decoders in parallel but Kodi is not.
Remove not needed delays. Check correct free_len when adding new chunk to hardware decoder input buffer. 'DequeueBuffer': do return EAGAIN when no new frame is decoded. But this does not mean the frame buffer is empty at all. Reset the decoder when no new frame is available within the new timeout, default is 5s. 'GetPicture': signal VC_NONE if DequeueBuffer failed and hardware buffer is not empty
av_grow_packet() allocates a dynamic buffer which must be freed when we close the decoder
This closes CoreELEC#11.
The <EGL/fbdev_window.h> include was missing and native window was NULL as _FBDEV_WINDOW_H_ was not defined.
If 'dovi.ko' is available enable the DV option.
If the mode switch is really required is checked afterwards in WinSystemAmlogic system.
The driver need first to clean up on video off.
When a stream starts, the hardware decoder buffer is initially empty, so no new frame is available for decoding. The stall detection logic did not account for this state and kept retrying indefinitely, causing an endless loop.
Keep the udev monitor active across hotplug events and defer HotplugEvent() processing to the window-system message pump. This avoids stopping the monitor from its callback and keeps DRM hotplug handling on Kodi's main thread.
The lazy read in IsHDRDisplay never cleared old flags, so a sink swap could keep the previous display's capabilities, and the codec could query the cache before anything filled it. Read hdr_cap and dv_cap at init and on hotplug instead, rebuilding the object each time.
The else got lost in an earlier rework, so the warning fired on every hotplug.
First frame is only used to configure the render.
Visibility was decided once at boot and never revisited, so a sink change could leave the display settings wrongly shown or hidden for the session. Re-evaluate it on display events from the live display verdict. The settings chained by enable dependencies stay device-keyed so a disabled row always has its cause on screen.
The statics latched the display verdict at the first call, so a sink swap left the demuxer's dual-layer handling frozen on the old display while the decoder followed the live verdict.
Force the Player-Led policy to have DV converted to the highest possible HDR format supported by the connected TV.
m_nalLengthSize was only read from hvcC, so it stayed 0 for H.264 and every caller taking the length-prefixed path fell through to Annex-B start-code scanning on avcC packets, finding no NAL units at all. Read lengthSizeMinusOne from avcC byte 4, before the extradata is rewritten to Annex-B. This close CoreELEC#75.
OpenDefaultStreams dereferences the result of m_pDemuxer->GetStream() without a null check. On the DVD menu domain the demuxer holds no streams, while the selection streams come from libdvdnav with source STREAM_SOURCE_NAV and a nav index as id, so the lookup returns nullptr and Kodi segfaults before the first stream is opened. Only demuxer streams can carry the dual layer flags, so restrict the probe to STREAM_SOURCE_DEMUX and verify the stream exists and really is a video stream before casting. CDVDDemux::GetStream() ignores the demuxer id and looks up by stream id alone across all stream types, so the cast was unchecked for type as well. Fixes: 2a9a87e ("Videoplayer: open base layer as default on dual layer video")
The 1000/1001 modes divide by 1.001f, which lands one ULP below the rate the
player derives from the same ratio in double:
(float)(24/1.001f) 23.976022720336914
(float)(24/1.001) 23.976024627685547
So == is false and CheckEnableClockSync()'s perfect match test cannot fire.
Dividing in double makes the two match bit for bit. Integer modes never divide.
The widening is written out because the build is -Werror=double-promotion.
Signed-off-by: Olivier Allauzen <olivier.allauzen@gmail.com>
GetPicture derives each frame's duration from the gap to the previous timestamp; a repeated or backwards PTS produced a nonsense duration. Fall back to the stream's nominal frame duration when the timestamp does not advance. GetPicture()'s fallback duration computed video_rate * DVD_TIME_BASE in unsigned int. With DVD_TIME_BASE = 1000000 that overflows once video_rate goes above 4294, i.e. content below ~22.35 fps, before the widening to double - a wrong duration on low-fps sources. Widen video_rate first. Signed-off-by: allolive <160342668+allolive@users.noreply.github.com>
Get<T>() returns `T value;` after `file >> value`. If the read never runs - the
open failed, or the file is empty - value comes back uninitialised, and the
optional still says it has a value, so value_or() does not help.
Initialise it, so a failed read gives T{}. Successful reads are unchanged. The
test covers a missing node and an empty one.
Signed-off-by: allolive <160342668+allolive@users.noreply.github.com>
Four functions call value() on a CSysfsPath read. Get() only returns nullopt when the read itself fails, so the throw is unlikely, but it is unhandled and value_or costs nothing. One of them is reachable: disp_cap_3d comes from the user's own userdata directory. Put a directory at that path, on a sink that reports 3D, and the read fails with EISDIR - value() then throws out of the app thread. The rest are amhdmitx nodes and /proc/cmdline, which do not fail. Signed-off-by: allolive <160342668+allolive@users.noreply.github.com>
aml_amdv_wait() reads amdv_wait_delay without checking the node exists. Without aml_media it is missing, and the read returns a default rather than an error. CRenderManager treats that number as a delay and counts it down one call at a time. Check the node first and return 0 if it is not there. Signed-off-by: allolive <160342668+allolive@users.noreply.github.com>
Portisch
force-pushed
the
aml-5.15.196-22.0
branch
4 times, most recently
from
September 14, 2026 18:48
6c4347c to
23448cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A few small patches for things that look like they could go wrong: values that can be read before they are set, copies and retries without a bound, and objects read from one thread while another rebuilds them.
Nothing here came from a reported failure. They are split into a few small pull requests so that one patch that is not wanted/needs discussion does not hold up the others.
Motivation and context
Reading the code, these look like they could bite. None of them has been seen to.
How has this been tested?
Regular use looks stable on an Amlogic S922X-J (g12b) box on CoreELEC 22 - playback, seeking, mode switches, Dolby Vision and non-Dolby-Vision content, decoder open and close. Nothing has hit the failure paths themselves.
What is the effect on users?
Maybe stability improvements.
Screenshots (if appropriate):
N/A
Types of change
Checklist: