Improving infra for basic image fitting - #12
Merged
Merged
Conversation
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a major redesign of the inference configuration and documentation to support three inference methods: NUTS/MCMC, MAP, and Variational Inference (VI). The changes unify the configuration structure, update the documentation throughout to reflect method-agnostic inference, and introduce method-aware diagnostics and output handling. The default and example configurations are updated for clarity and to match external references. This makes the inference pipeline more flexible and easier to use for different workflows.
Inference engine and configuration redesign:
InferenceConfig, with method-specific config blocks (nuts_config,map_config,vi_config) and unified handling of outputs via ArviZInferenceData(shine/config.py,shine/inference.py). [1] [2] [3]method: mapand method-specific config blocks, matching externalngmixreferences and clarifying parameter choices (configs/validation/level0_base.yaml, [1] [2].Documentation updates for method-agnostic inference:
docs/architecture.md, [1];docs/api/inference.md, [2];docs/api/config.md, [3];docs/configuration.md, [4] [5];docs/getting-started.md, [6] [7];docs/validation/level0.md, [8] [9] [10] [11] [12];docs/validation/index.md, [13];docs/validation/batched.md, [14];docs/api/validation/cli.md, [15];docs/api/validation/extraction.md, [16].Method-aware diagnostics and output handling:
docs/api/validation/extraction.md, [1];docs/validation/level0.md, [2] [3] [4].Improved clarity and external consistency:
ngmix), clarified differences, and improved explanatory comments (configs/validation/level0_base.yaml, configs/validation/level0_base.yamlL1-R37).Refactoring and cleanup:
shine/config.py, [1] [2].These changes make the codebase and documentation more flexible, consistent, and easier to use for a variety of inference workflows.