240 architecture implement quality control pipeline orchestration - #243
Merged
roryclaydon1994 merged 10 commits intoAug 27, 2026
Merged
Conversation
jeipollack
force-pushed
the
240-architecture-implement-quality-control-pipeline-orchestration
branch
from
August 18, 2026 14:13
89a896b to
ae8b21b
Compare
jeipollack
force-pushed
the
240-architecture-implement-quality-control-pipeline-orchestration
branch
2 times, most recently
from
August 21, 2026 09:52
1c43b37 to
b64ea75
Compare
jeipollack
force-pushed
the
240-architecture-implement-quality-control-pipeline-orchestration
branch
from
August 25, 2026 15:19
b64ea75 to
34b408d
Compare
added 6 commits
August 26, 2026 14:21
- Initialize the MetricsRegistry in the pipeline constructor - Instantiate enabled quality metric implementations from configuration - Add unit tests for valid and invalid metric configurations
- Add helpers to instantiate enabled metrics and rejection policies - Build the processing sequence for resource resolution, metric computation, and policy application - Add unit and integration tests for the orchestration - Clean up whitespace in the quality control configuration fixture
jeipollack
force-pushed
the
240-architecture-implement-quality-control-pipeline-orchestration
branch
from
August 26, 2026 12:22
97f575e to
c0b7954
Compare
jeipollack
marked this pull request as ready for review
August 26, 2026 12:37
roryclaydon1994
left a comment
roryclaydon1994
left a comment
There was a problem hiding this comment.
Review Feedback
Very complete, great tests and design.
I think in terms of design, I would suggest splitting out the instantiate components of the run method of QualityControlPipeline so that run only has the responsibility of running and all loading and resolving responsibilities are in a separate method.
I would also suggest sprinkling in some logging statements as you see fit to help observability.
added 4 commits
August 27, 2026 10:59
… skipped/processed
- Rename rejection_masks to validity_masks - Define boolean validity mask in RejectionPolicy apply method doc string - Add pipeline integration test and fixture for multiple rejection policies - Rename test test_pipeline_run to test_pipeline_run_single_rejection_policy
Contributor
Author
|
Thanks a mill, @roryclaydon1994! I addressed each comment and made some updates. I also corrected some syntax errors in the public |
roryclaydon1994
deleted the
240-architecture-implement-quality-control-pipeline-orchestration
branch
August 27, 2026 15:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implement a minimal quality control pipeline orchestrator; it builds the processing sequence for resource resolution, metric computation, and policy application.
Closes #240 #246
What’s changed
QualityControlContextclass definitionQualityControlResultfor metric results and rejection masksThresholdRejectionPolicyHow to test / verify
Scope
Changelog
The quality control pipeline interface and configuration are still being finalised. A changelog fragment will be added with the PR that finalises the user-facing pipeline behaviour.
Reviewer Checklist
develop, ormainfor release PRs)ruff)Next Steps / Notes (if applicable)
The next step is to implement preparation of missing resources so that the resource resolution stage can provide all resources required by enabled quality metrics.